Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable application menu #1139

Open
mahalakshme opened this issue Jan 10, 2024 · 2 comments
Open

Configurable application menu #1139

mahalakshme opened this issue Jan 10, 2024 · 2 comments

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jan 10, 2024

Need:

  • Need to display different icons in the bottom drawer
  • As a side effect can also use to hide some menus like 'fast sync' in the More section

Analysis:

  • Make it similar to custom dashboards - so that can reuse the UI and hence less effort.

Acceptance criteria:

  • First menu section need to display between Home and More button. Rest of the sections will appear in groups under the More.
  • Ability to change the order of menu sections like already present
  • In the 'Add menu items' selection drop down - menu items configured need to display along with the default menu items(like standard report cards) along with all dashboard names.
  • Migration to insert the default menus into the db for existing orgs -
  • When a org is created, the MyApplicationMenu should already be present
  • Change the privileges of 'Edit Application Menu' to 'Edit Application Menu and Menu items' and the same privileges configured now need to be applicable to both application menu and menu item
  • Add ability to add icon to offline dashboard like it exists for offline report cards
  • If the View type is Primary, the no of menu items need to be between 1 and 3. - accordingly need to change the mockups.
  • The current 'Application Menu' need to be renamed to 'Menu Item' and this card covers the 'Application Menu' - accordingly highlight the navigation menu and change the URL.
  • The other conditions like 'privileges to render Register button' or 'to render News menu item based on availability of News' will be applied on top of what is configured here.

Mockups:

On click of Application menu, the page below will display,
Menus Season 2.pdf

Out of scope

  • Being able to configure different primary menu based on user groups
  • Any changes in mobile app

Cons:

Based on the overall workflow what needs to be shortcut should become determined - UI should be determined based on the process configuration and we should not have a separate configuration for UI - to minimise the amount of configuration

Discussion notes - ignore:

Suggestion:

Option 1:
Being able to configure multiple dashboards vs register and search

Option 2:

  • Lets see if people use by having just one secondary dashboard
    -- 7 orgs more than 2 dashboards - in many of these they dont even have primary configured.
  • People who dont use register and search, use the app itself for less operations.

Option 3:
extending menu item
Register and Search existing conditionality
similar to dashboard - but fixed sets not unlimited
migrate now itself to avoid duplicate code similar to MyDashboard and CustomDashboard

Option 4:
Showing dashboards in the home page

Option 5:
stabilisation
vs
improving product

Need:

Frequently its not always the register and search that user needs.

Acceptance criteria:

  • In the Dashboard tab of a user group in webapp, on the right of 'Is Primary' column, add a new column called 'Is Secondary' where one of the dashboards can be marked as Secondary
  • The dashboard marked as Secondary need to display before the More icon. Adjust the styling and spacing such that all icons are of same size, etc.,
  • Use the dashboard icon under Material Icons here as the icon to indicate.
  • The name should be the name of the dashboard.
  • Clicking on it need to take to the dashboard

Considerations made:

  • In many apps, like PhonPe, Clock, Bumble, there are 5 icons in the bottom bar

Questions:

Will Stats in presentation come later

Other options considered:

  1. Customisable and extensible: Too much work for which we dont know if there is utility for the future.
  • Add a tab for 'Frequently accessed' - in the User Groups
  • In that Home and More cant be removed by anyone,
    --- So, Search, Register, different dashboards - they can order - based on priority - the top 2 need to display between Home and More and Rest under More section in the order arranged.
  1. Display as report cards itself - user will get confused. now there is a hierarchial structure which would be easy for the user to navigate. This kind of bottom drawer shortcuts is available in most of the app.s
  2. Material design already tried and not user-friendly.

Suggestions:

  • Dashboard icon on the bottom - take to list of dashboards
  • dashboard tied to be user groups - fix
  • dashboard on the home screen
  • generic dashboard -
  • List of dahsboard - itself of home screen.
  • flexibility - many orgs dont need register and search, in such cases they can have more than one dashboard as shortcut at bottom - then dashboard icon is needed.
@vinayvenu
Copy link
Member

@mahalakshme

  • Why can't home be removed?
  • Search is right now based on another criteria - number of subjects. Is this supposed to stay as is?
  • Register is based on permissions. Do we have to keep this behaviour along with the preferred order?
  • Should we keep the "Mark as Home Dashboard" part in the Dashboards section of the User groups?
  • How should we store this information?
  • Any data migrations expected?
  • Is this an epic or one story to deal with both app designer/admin and avni-client?
  • Why do we call it frequently accessed?
  • I have a feeling we should make this a common list instead of something per user group. Lets look at the existing stuff and then decide

@mahalakshme
Copy link
Contributor Author

@vinayvenu good point, regarding removing Home, I thought we need to indicate where the user is currently in, but realised actually not required.

I feel we can simplify this a lot: Remove home for all implementations, in the Dashboards of UserGroups in webapp itself, add ability to mark one of them if needed to appear in bottom drawer, considering we dont ve the need for more shortcuts for now. continue to display Register and Search as is now. So that we can make sure we are not building anything unnecessary as of now.

@mahalakshme mahalakshme transferred this issue from avniproject/avni-product Feb 28, 2024
@mahalakshme mahalakshme changed the title Configurable bottom drawer Configurable bottom drawer and menus Feb 28, 2024
@mahalakshme mahalakshme changed the title Configurable bottom drawer and menus Configurable application menu Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Analysis Review
Development

No branches or pull requests

2 participants