Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpputest: Parse msrp PDUs #117

Open
davidcemin opened this issue Oct 31, 2014 · 6 comments
Open

Cpputest: Parse msrp PDUs #117

davidcemin opened this issue Oct 31, 2014 · 6 comments
Assignees

Comments

@davidcemin
Copy link
Contributor

No description provided.

@pinealservo
Copy link
Contributor

Was this really meant to be a bug, or an enhancement to the test suite?

@andrew-elder
Copy link

I think an enhancement. I've updated the tags.

@pinealservo
Copy link
Contributor

OK, thanks for clarifying. Can you think of additional MSRP PDU tests to include aside from the ones I already added in open-avb-next? I tried to be comprehensive, but I may have missed some.

@andrew-elder
Copy link

Do we test multiple numValues decoding? ie Where first value in incremented to create additional attributes.

@andrew-elder
Copy link

Also, I think protocol version testing should pass as it is part of AVnu testing.

@pinealservo
Copy link
Contributor

We're definitely testing muliple numValues; I based many of the test packets on some real-world packets, and there was a lot of numValues usage there.

Apparently I left a note to myself in the comments about protocol version testing, so I guess there's that left to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants