chore: try cuprite (#2371)

* chore: try cuprite * run appraisal * add appraisals back * remove failing test * wip * wip * bundle * update rails * click and alert fixes * fix tricky to spot issue :D * increase default_max_wait_time * fix tabs spec * try to improve wait_for_loaded * fix save & decrease capybara default max wait time * refactor save * fix save * uncomment and fix code field spec * dont break on timeout * trigger tests * trigger tests * trigger tests * trigger tests * rm focus * mv spec to right dir * wip * try fix for flaky test * better error * have_current_path refactor * change path check * bye bye flakiness * trigger click * try Capybara.save_path * standard * standard * comment * lint fixes * more lint * linter... * rm flakiness report for now --------- Co-authored-by: Paul Bob <paul.ionut.bob@gmail.com>
avo-hq · Feb 13, 2024 · 8abe170 · 8abe170
1 parent 4c8efaf
commit 8abe170
Show file tree

Hide file tree

Showing 66 changed files with 380 additions and 433 deletions.
diff --git a/.standard.yml b/.standard.yml
@@ -1,6 +1,7 @@
 fix: true               # default: false
 parallel: true          # default: false
 format: progress        # default: Standard::Formatter
+ruby_version: 3.3.0     # default: RUBY_VERSION
 default_ignores: true   # default: true
 
 ignore:                 # default: []

diff --git a/Gemfile b/Gemfile
@@ -79,12 +79,10 @@ end
 
 group :test do
   gem "rspec-rails", "~> 6.0", ">= 6.0.3"
+  gem "rspec-retry", "~> 0.6.2"
   gem "rails-controller-testing"
-  # Adds support for Capybara system testing and selenium driver
   gem "capybara"
-  gem "selenium-webdriver"
-  # Easy installation and use of web drivers to run system tests with browsers
-  gem "webdrivers", ">= 5.3.0"
+  gem "cuprite"
   gem "fuubar"
   gem "simplecov", require: false
   gem "simplecov-cobertura"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -175,6 +175,9 @@ GEM
     crass (1.0.6)
     cssbundling-rails (1.4.0)
       railties (>= 6.0.0)
+    cuprite (0.15)
+      capybara (~> 3.0)
+      ferrum (~> 0.14.0)
     database_cleaner-active_record (2.1.0)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0.0)
@@ -206,6 +209,11 @@ GEM
       railties (>= 5.0.0)
     faker (3.2.3)
       i18n (>= 1.8.11, < 2)
+    ferrum (0.14)
+      addressable (~> 2.5)
+      concurrent-ruby (~> 1.1)
+      webrick (~> 1.7)
+      websocket-driver (>= 0.6, < 0.8)
     ffi (1.16.3)
     friendly_id (5.5.1)
       activerecord (>= 4.0.0)
@@ -410,6 +418,8 @@ GEM
       rspec-expectations (~> 3.12)
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
+    rspec-retry (0.6.2)
+      rspec-core (> 3.3)
     rspec-support (3.13.0)
     rubocop (1.59.0)
       json (~> 2.3)
@@ -433,11 +443,6 @@ GEM
     ruby-vips (2.2.0)
       ffi (~> 1.12)
     ruby2_keywords (0.0.5)
-    rubyzip (2.3.2)
-    selenium-webdriver (4.10.0)
-      rexml (~> 3.2, >= 3.2.5)
-      rubyzip (>= 1.2.2, < 3.0)
-      websocket (~> 1.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -498,7 +503,7 @@ GEM
     thor (1.3.0)
     tilt (2.3.0)
     timeout (0.4.1)
-    turbo-rails (2.0.0)
+    turbo-rails (2.0.1)
       actionpack (>= 6.0.0)
       activejob (>= 6.0.0)
       railties (>= 6.0.0)
@@ -519,16 +524,11 @@ GEM
       activemodel (>= 6.0.0)
       bindex (>= 0.4.0)
       railties (>= 6.0.0)
-    webdrivers (5.3.1)
-      nokogiri (~> 1.6)
-      rubyzip (>= 1.3.0)
-      selenium-webdriver (~> 4.0, < 4.11)
-    webmock (3.20.0)
+    webmock (3.19.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
     webrick (1.8.1)
-    websocket (1.2.10)
     websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
@@ -561,6 +561,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  cuprite
   database_cleaner-active_record
   devise
   dotenv-rails
@@ -594,9 +595,9 @@ DEPENDENCIES
   redis (~> 5.0)
   ripper-tags
   rspec-rails (~> 6.0, >= 6.0.3)
+  rspec-retry (~> 0.6.2)
   rubocop
   rubocop-shopify
-  selenium-webdriver
   simplecov
   simplecov-cobertura
   solargraph
@@ -608,7 +609,6 @@ DEPENDENCIES
   test-prof
   tzinfo-data
   web-console (>= 3.3.0)
-  webdrivers (>= 5.3.0)
   webmock
   zeitwerk
 

diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile b/gemfiles/rails_6.1_ruby_3.1.4.gemfile
@@ -57,10 +57,10 @@ end
 
 group :test do
   gem "rspec-rails", "~> 6.0", ">= 6.0.3"
+  gem "rspec-retry", "~> 0.6.2"
   gem "rails-controller-testing"
   gem "capybara"
-  gem "selenium-webdriver"
-  gem "webdrivers", ">= 5.3.0"
+  gem "cuprite"
   gem "fuubar"
   gem "simplecov", require: false
   gem "simplecov-cobertura"

diff --git a/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock b/gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock
@@ -6,7 +6,7 @@ PATH
 PATH
   remote: ..
   specs:
-    avo (3.3.5)
+    avo (3.3.6)
       actionview (>= 6.1)
       active_link_to
       activerecord (>= 6.1)
@@ -159,6 +159,9 @@ GEM
     crass (1.0.6)
     cssbundling-rails (1.4.0)
       railties (>= 6.0.0)
+    cuprite (0.15)
+      capybara (~> 3.0)
+      ferrum (~> 0.14.0)
     database_cleaner-active_record (2.1.0)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0.0)
@@ -188,6 +191,11 @@ GEM
       railties (>= 5.0.0)
     faker (3.2.3)
       i18n (>= 1.8.11, < 2)
+    ferrum (0.14)
+      addressable (~> 2.5)
+      concurrent-ruby (~> 1.1)
+      webrick (~> 1.7)
+      websocket-driver (>= 0.6, < 0.8)
     ffi (1.16.3)
     friendly_id (5.5.1)
       activerecord (>= 4.0.0)
@@ -278,6 +286,8 @@ GEM
     net-smtp (0.4.0.1)
       net-protocol
     nio4r (2.7.0)
+    nokogiri (1.16.2-arm64-darwin)
+      racc (~> 1.4)
     nokogiri (1.16.2-x86_64-linux)
       racc (~> 1.4)
     orm_adapter (0.5.0)
@@ -372,6 +382,8 @@ GEM
       rspec-expectations (~> 3.12)
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
+    rspec-retry (0.6.2)
+      rspec-core (> 3.3)
     rspec-support (3.13.0)
     rubocop (1.59.0)
       json (~> 2.3)
@@ -394,11 +406,6 @@ GEM
     ruby-progressbar (1.13.0)
     ruby-vips (2.2.0)
       ffi (~> 1.12)
-    rubyzip (2.3.2)
-    selenium-webdriver (4.10.0)
-      rexml (~> 3.2, >= 3.2.5)
-      rubyzip (>= 1.2.2, < 3.0)
-      websocket (~> 1.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -458,7 +465,7 @@ GEM
     thor (1.3.0)
     tilt (2.3.0)
     timeout (0.4.1)
-    turbo-rails (2.0.0)
+    turbo-rails (2.0.1)
       actionpack (>= 6.0.0)
       activejob (>= 6.0.0)
       railties (>= 6.0.0)
@@ -479,15 +486,11 @@ GEM
       activemodel (>= 6.0.0)
       bindex (>= 0.4.0)
       railties (>= 6.0.0)
-    webdrivers (5.3.1)
-      nokogiri (~> 1.6)
-      rubyzip (>= 1.3.0)
-      selenium-webdriver (~> 4.0, < 4.11)
     webmock (3.20.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    websocket (1.2.10)
+    webrick (1.8.1)
     websocket-driver (0.7.6)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
@@ -497,6 +500,7 @@ GEM
     zeitwerk (2.6.13)
 
 PLATFORMS
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
@@ -519,6 +523,7 @@ DEPENDENCIES
   chartkick
   countries
   cssbundling-rails
+  cuprite
   database_cleaner-active_record
   devise
   dotenv-rails
@@ -553,9 +558,9 @@ DEPENDENCIES
   redis (~> 5.0)
   ripper-tags
   rspec-rails (~> 6.0, >= 6.0.3)
+  rspec-retry (~> 0.6.2)
   rubocop
   rubocop-shopify
-  selenium-webdriver
   simplecov
   simplecov-cobertura
   solargraph
@@ -567,9 +572,8 @@ DEPENDENCIES
   test-prof
   tzinfo-data
   web-console (>= 3.3.0)
-  webdrivers (>= 5.3.0)
   webmock
   zeitwerk
 
 BUNDLED WITH
-   2.2.32
+   2.4.7
diff --git a/gemfiles/rails_6.1_ruby_3.2.2.gemfile b/gemfiles/rails_6.1_ruby_3.2.2.gemfile
@@ -57,10 +57,10 @@ end
 
 group :test do
   gem "rspec-rails", "~> 6.0", ">= 6.0.3"
+  gem "rspec-retry", "~> 0.6.2"
   gem "rails-controller-testing"
   gem "capybara"
-  gem "selenium-webdriver"
-  gem "webdrivers", ">= 5.3.0"
+  gem "cuprite"
   gem "fuubar"
   gem "simplecov", require: false
   gem "simplecov-cobertura"