New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: try cuprite #2371
chore: try cuprite #2371
Conversation
Code Climate has analyzed commit 32093b9 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6914 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6914 lines exceeds the maximum allowed for the inline comments feature.
1b70b31
to
ba567ff
Compare
@adrianthedev this one is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
rubocop
spec/dummy/lib/formaters/flakiness.rb|38 col 3| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|38 col 5| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|40 col 40| [Corrected] Layout/SpaceAfterComma: Space missing after comma.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
spec/dummy/lib/formaters/flakiness.rb|43 col 3| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|43 col 5| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
This PR has been merged into Please check the release guide for more information. |
Description
This PR switches the system testing framework from selenium with webdrivers to cuprite in the hope of faster testing and more ruby-oriented solution.
There are still some failing tests.
Resources
Checklist: