Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try cuprite #2371

Merged
merged 42 commits into from Feb 13, 2024
Merged

chore: try cuprite #2371

merged 42 commits into from Feb 13, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Jan 16, 2024

Description

This PR switches the system testing framework from selenium with webdrivers to cuprite in the hope of faster testing and more ruby-oriented solution.

There are still some failing tests.

Resources

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Jan 16, 2024

Code Climate has analyzed commit 32093b9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6914 lines exceeds the maximum allowed for the inline comments feature.

lib/avo/test_helpers.rb Show resolved Hide resolved
lib/avo/test_helpers.rb Show resolved Hide resolved
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6914 lines exceeds the maximum allowed for the inline comments feature.

@Paul-Bob Paul-Bob self-assigned this Feb 9, 2024
@Paul-Bob Paul-Bob marked this pull request as ready for review February 9, 2024 10:26
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Feb 9, 2024

@adrianthedev this one is ready

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Feb 9, 2024

lib/avo/test_helpers.rb Outdated Show resolved Hide resolved
spec/dummy/config/environments/test.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

rubocop

spec/dummy/lib/formaters/flakiness.rb|38 col 3| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|38 col 5| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|40 col 40| [Corrected] Layout/SpaceAfterComma: Space missing after comma.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
spec/dummy/lib/formaters/flakiness.rb|43 col 1| [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
spec/dummy/lib/formaters/flakiness.rb|43 col 3| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.
spec/dummy/lib/formaters/flakiness.rb|43 col 5| [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected.

spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
spec/dummy/lib/formaters/flakiness.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit 8abe170 into main Feb 13, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the chore/try-cuprite branch February 13, 2024 09:00
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants