Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heading can't be the first item in your resource #1124

Merged

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Aug 5, 2022

Description

Fixes #1123

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Configure a resource to have a heading as the first item in the DSL
  2. Observe the show page loads

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Aug 5, 2022
@codeclimate
Copy link

codeclimate bot commented Aug 5, 2022

Code Climate has analyzed commit dc3e748 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1124 (629b3b8) into main (fed8189) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 629b3b8 differs from pull request most recent head dc3e748. Consider uploading reports for the commit dc3e748 to get more accurate results

@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         530      530           
  Lines       10560    10561    +1     
=======================================
+ Hits         9946     9947    +1     
  Misses        614      614           
Impacted Files Coverage Δ
lib/avo/concerns/has_fields.rb 75.00% <100.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adrianthedev adrianthedev merged commit be5194a into main Aug 5, 2022
@adrianthedev adrianthedev deleted the fix/heading-cant-be-the-first-item-in-your-resource branch August 5, 2022 14:59
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError on heading when upgrading from 2.7.0 ➡️ 2.11.0
1 participant