Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue of showing custom label for actionlist #1395

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix: issue of showing custom label for actionlist #1395

merged 2 commits into from
Nov 4, 2022

Conversation

sarvaiyanidhi
Copy link
Contributor

Description

Fix the issue of showing custom label for actionlist

Fixes #1330

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codeclimate
Copy link

codeclimate bot commented Nov 4, 2022 •
edited
Loading

Code Climate has analyzed commit 0a50aed and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

Thank you for your contribution @sarvaiyanidhi.

How about this approach where we change the label for the ActionsController?

@adrianthedev adrianthedev added the Enhancement New feature or request label Nov 4, 2022
@adrianthedev adrianthedev merged commit 78c8399 into avo-hq:main Nov 4, 2022
@sarvaiyanidhi
Copy link
Contributor Author

Thank you for feedback. Your approach is much better. Taken note of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can’t change the label of actions menu
2 participants
@sarvaiyanidhi @adrianthedev