Fallback to resources class / link to child resource feature

[elassadi]

Description

Link to child resources

A small bug.
if the parent resource is the same as the base class or if the child class is missing we fallback to the parent class.
We may as well raise an exception ?

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit f5248b3 and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

Hey @elassadi. Can you share an example where this bug occurs in the dummy app?

[elassadi]

I just prepared https://github.com/elassadi/avo/tree/demo/reference-to-base-class to show the case

• hit http://127.0.0.1:3000/admin/resources/people to show the bug
• merge elassadi:bugfix/reference-to-base-class to solve the issue

[adrianthedev]

OK! Got it! I see the issue and the fix now. Thank you!

Can I ask you to add a spec for this so we can bullet proof it?

[elassadi]

I don't see any useful specs to cover a missing Model.
I am not even sure if we should not let the exception being raised
But since it will affect parent resources as well. I opt to use a rescue (fallback) in our case.
If I got some time, I will think about adding meaningful specs, for now I don't see any

[adrianthedev]

I think it would be enough adding that Brother model, seed the DB with a record, and make sure the page does not crash like before.

I'll look into it and see if I can add one.