Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: height option for Code field #179

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

mihaimdm22
Copy link
Contributor

@mihaimdm22 mihaimdm22 commented Nov 2, 2020

Instead of rows and auto I thought about implementing a height option that will enforce the size of the field(if specified), otherwise it defaults to auto and the size will fit all content. I think it will be easier for the administrator to configure and also makes sense to default to auto. Let me know what you think about this.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #179 into master will increase coverage by 0.56%.
The diff coverage is 94.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   96.03%   96.59%   +0.56%     
==========================================
  Files          87      130      +43     
  Lines        1890     3551    +1661     
==========================================
+ Hits         1815     3430    +1615     
- Misses         75      121      +46     
Impacted Files Coverage Δ
lib/avo/app/tools_manager.rb 50.00% <50.00%> (ø)
spec/dummy/app/policies/user_policy.rb 56.25% <53.33%> (ø)
spec/dummy/app/avo/filters/published_filter.rb 66.66% <66.66%> (ø)
lib/avo/app/action.rb 80.00% <80.00%> (ø)
lib/avo/engine.rb 85.71% <85.71%> (ø)
lib/avo/app/fields/boolean_field.rb 93.75% <87.50%> (ø)
lib/avo/app/app.rb 89.70% <89.70%> (ø)
lib/avo/app/fields/key_value_field.rb 90.90% <90.90%> (ø)
.../avo/app/fields/field_extensions/has_field_name.rb 91.66% <91.66%> (ø)
...lds/field_extensions/visible_in_different_views.rb 92.85% <92.85%> (ø)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db9f21...e42cd4f. Read the comment docs.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG!

Pushed the same change to show view too!

@adrianthedev adrianthedev merged commit d3259ca into master Nov 2, 2020
@adrianthedev adrianthedev deleted the feat/auto-and-rows-options-for-code branch November 2, 2020 20:06
@adrianthedev adrianthedev changed the title feat: height option for Code field fix: height option for Code field Nov 3, 2020
@adrianthedev adrianthedev added Fix and removed Feature labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants