Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tabs persistence when tab name has spaces #2278

Merged
merged 1 commit into from Dec 29, 2023
Merged

fix: tabs persistence when tab name has spaces #2278

merged 1 commit into from Dec 29, 2023

Conversation

Paul-Bob
Copy link
Contributor

Description

This PR removes the double group_param definition moving it to Avo::Resources::Items::TabGroup and delegating to that class when usage is necessary.

Fixes #2265

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob added the Fix label Dec 21, 2023
@Paul-Bob Paul-Bob self-assigned this Dec 21, 2023
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 21, 2023

Code Climate has analyzed commit 679b425 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev changed the title fix: tabs persistence when tab name have spaces fix: tabs persistence when tab name has spaces Dec 29, 2023
@adrianthedev adrianthedev merged commit 5fe3bc9 into main Dec 29, 2023
18 checks passed
@adrianthedev adrianthedev deleted the fix/tabs_persistence_when_tab_name_have_spaces branch December 29, 2023 13:28
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab not persistent if tab name has spaces
2 participants
@Paul-Bob @adrianthedev