Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try cuprite #2371

Merged
merged 42 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
853cd8c
chore: try cuprite
adrianthedev Jan 16, 2024
dbbb669
run appraisal
adrianthedev Jan 16, 2024
90782dd
Merge branch 'main' into chore/try-cuprite
adrianthedev Jan 16, 2024
64c41bb
add appraisals back
adrianthedev Jan 16, 2024
656b1c8
remove failing test
adrianthedev Jan 22, 2024
b5e5784
Merge branch 'main' into chore/try-cuprite
adrianthedev Jan 22, 2024
ba567ff
wip
adrianthedev Jan 22, 2024
17a4763
wip
Paul-Bob Feb 8, 2024
a06c1d1
Merge branch 'main' into chore/try-cuprite
Paul-Bob Feb 8, 2024
0f51f3f
bundle
Paul-Bob Feb 8, 2024
b8cf1b9
update rails
Paul-Bob Feb 8, 2024
1cd511f
click and alert fixes
Paul-Bob Feb 9, 2024
2692879
fix tricky to spot issue :D
Paul-Bob Feb 9, 2024
16ee63a
increase default_max_wait_time
Paul-Bob Feb 9, 2024
0dc1c92
fix tabs spec
Paul-Bob Feb 9, 2024
5f85787
try to improve wait_for_loaded
Paul-Bob Feb 9, 2024
db6896c
fix save & decrease capybara default max wait time
Paul-Bob Feb 9, 2024
ad136ce
refactor save
Paul-Bob Feb 9, 2024
c3da66a
fix save
Paul-Bob Feb 9, 2024
e3f73f8
uncomment and fix code field spec
Paul-Bob Feb 9, 2024
682259a
dont break on timeout
Paul-Bob Feb 9, 2024
87b6f46
trigger tests
Paul-Bob Feb 9, 2024
c91ef54
trigger tests
Paul-Bob Feb 9, 2024
f3308bd
trigger tests
Paul-Bob Feb 9, 2024
dcf4cc6
trigger tests
Paul-Bob Feb 9, 2024
f4f08d9
rm focus
Paul-Bob Feb 9, 2024
2fb92a8
mv spec to right dir
Paul-Bob Feb 9, 2024
38abb37
wip
Paul-Bob Feb 9, 2024
ff97503
try fix for flaky test
Paul-Bob Feb 9, 2024
6a254bb
better error
Paul-Bob Feb 9, 2024
b46f78b
have_current_path refactor
Paul-Bob Feb 9, 2024
9dce724
change path check
Paul-Bob Feb 9, 2024
05f5a60
bye bye flakiness
Paul-Bob Feb 9, 2024
e68459b
trigger click
Paul-Bob Feb 9, 2024
80f40de
try Capybara.save_path
Paul-Bob Feb 12, 2024
283f147
standard
Paul-Bob Feb 12, 2024
8e3506c
standard
Paul-Bob Feb 12, 2024
e0acf9c
comment
Paul-Bob Feb 12, 2024
6d2dee0
lint fixes
Paul-Bob Feb 12, 2024
9ab8f92
more lint
Paul-Bob Feb 12, 2024
55f1c1e
linter...
Paul-Bob Feb 12, 2024
32093b9
rm flakiness report for now
Paul-Bob Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .standard.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
fix: true # default: false
parallel: true # default: false
format: progress # default: Standard::Formatter
ruby_version: 3.3.0 # default: RUBY_VERSION
default_ignores: true # default: true

ignore: # default: []
Expand Down
6 changes: 2 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,10 @@ end

group :test do
gem "rspec-rails", "~> 6.0", ">= 6.0.3"
gem "rspec-retry", "~> 0.6.2"
gem "rails-controller-testing"
# Adds support for Capybara system testing and selenium driver
gem "capybara"
gem "selenium-webdriver"
# Easy installation and use of web drivers to run system tests with browsers
gem "webdrivers", ">= 5.3.0"
gem "cuprite"
gem "fuubar"
gem "simplecov", require: false
gem "simplecov-cobertura"
Expand Down
28 changes: 14 additions & 14 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ GEM
crass (1.0.6)
cssbundling-rails (1.4.0)
railties (>= 6.0.0)
cuprite (0.15)
capybara (~> 3.0)
ferrum (~> 0.14.0)
database_cleaner-active_record (2.1.0)
activerecord (>= 5.a)
database_cleaner-core (~> 2.0.0)
Expand Down Expand Up @@ -206,6 +209,11 @@ GEM
railties (>= 5.0.0)
faker (3.2.3)
i18n (>= 1.8.11, < 2)
ferrum (0.14)
addressable (~> 2.5)
concurrent-ruby (~> 1.1)
webrick (~> 1.7)
websocket-driver (>= 0.6, < 0.8)
ffi (1.16.3)
friendly_id (5.5.1)
activerecord (>= 4.0.0)
Expand Down Expand Up @@ -410,6 +418,8 @@ GEM
rspec-expectations (~> 3.12)
rspec-mocks (~> 3.12)
rspec-support (~> 3.12)
rspec-retry (0.6.2)
rspec-core (> 3.3)
rspec-support (3.13.0)
rubocop (1.59.0)
json (~> 2.3)
Expand All @@ -433,11 +443,6 @@ GEM
ruby-vips (2.2.0)
ffi (~> 1.12)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
selenium-webdriver (4.10.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
Expand Down Expand Up @@ -498,7 +503,7 @@ GEM
thor (1.3.0)
tilt (2.3.0)
timeout (0.4.1)
turbo-rails (2.0.0)
turbo-rails (2.0.1)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
Expand All @@ -519,16 +524,11 @@ GEM
activemodel (>= 6.0.0)
bindex (>= 0.4.0)
railties (>= 6.0.0)
webdrivers (5.3.1)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0, < 4.11)
webmock (3.20.0)
webmock (3.19.1)
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.8.1)
websocket (1.2.10)
websocket-driver (0.7.6)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand Down Expand Up @@ -561,6 +561,7 @@ DEPENDENCIES
chartkick
countries
cssbundling-rails
cuprite
database_cleaner-active_record
devise
dotenv-rails
Expand Down Expand Up @@ -594,9 +595,9 @@ DEPENDENCIES
redis (~> 5.0)
ripper-tags
rspec-rails (~> 6.0, >= 6.0.3)
rspec-retry (~> 0.6.2)
rubocop
rubocop-shopify
selenium-webdriver
simplecov
simplecov-cobertura
solargraph
Expand All @@ -608,7 +609,6 @@ DEPENDENCIES
test-prof
tzinfo-data
web-console (>= 3.3.0)
webdrivers (>= 5.3.0)
webmock
zeitwerk

Expand Down
4 changes: 2 additions & 2 deletions gemfiles/rails_6.1_ruby_3.1.4.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ end

group :test do
gem "rspec-rails", "~> 6.0", ">= 6.0.3"
gem "rspec-retry", "~> 0.6.2"
gem "rails-controller-testing"
gem "capybara"
gem "selenium-webdriver"
gem "webdrivers", ">= 5.3.0"
gem "cuprite"
gem "fuubar"
gem "simplecov", require: false
gem "simplecov-cobertura"
Expand Down
34 changes: 19 additions & 15 deletions gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ PATH
PATH
remote: ..
specs:
avo (3.3.5)
avo (3.3.6)
actionview (>= 6.1)
active_link_to
activerecord (>= 6.1)
Expand Down Expand Up @@ -159,6 +159,9 @@ GEM
crass (1.0.6)
cssbundling-rails (1.4.0)
railties (>= 6.0.0)
cuprite (0.15)
capybara (~> 3.0)
ferrum (~> 0.14.0)
database_cleaner-active_record (2.1.0)
activerecord (>= 5.a)
database_cleaner-core (~> 2.0.0)
Expand Down Expand Up @@ -188,6 +191,11 @@ GEM
railties (>= 5.0.0)
faker (3.2.3)
i18n (>= 1.8.11, < 2)
ferrum (0.14)
addressable (~> 2.5)
concurrent-ruby (~> 1.1)
webrick (~> 1.7)
websocket-driver (>= 0.6, < 0.8)
ffi (1.16.3)
friendly_id (5.5.1)
activerecord (>= 4.0.0)
Expand Down Expand Up @@ -278,6 +286,8 @@ GEM
net-smtp (0.4.0.1)
net-protocol
nio4r (2.7.0)
nokogiri (1.16.2-arm64-darwin)
racc (~> 1.4)
nokogiri (1.16.2-x86_64-linux)
racc (~> 1.4)
orm_adapter (0.5.0)
Expand Down Expand Up @@ -372,6 +382,8 @@ GEM
rspec-expectations (~> 3.12)
rspec-mocks (~> 3.12)
rspec-support (~> 3.12)
rspec-retry (0.6.2)
rspec-core (> 3.3)
rspec-support (3.13.0)
rubocop (1.59.0)
json (~> 2.3)
Expand All @@ -394,11 +406,6 @@ GEM
ruby-progressbar (1.13.0)
ruby-vips (2.2.0)
ffi (~> 1.12)
rubyzip (2.3.2)
selenium-webdriver (4.10.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
simplecov (0.22.0)
docile (~> 1.1)
simplecov-html (~> 0.11)
Expand Down Expand Up @@ -458,7 +465,7 @@ GEM
thor (1.3.0)
tilt (2.3.0)
timeout (0.4.1)
turbo-rails (2.0.0)
turbo-rails (2.0.1)
actionpack (>= 6.0.0)
activejob (>= 6.0.0)
railties (>= 6.0.0)
Expand All @@ -479,15 +486,11 @@ GEM
activemodel (>= 6.0.0)
bindex (>= 0.4.0)
railties (>= 6.0.0)
webdrivers (5.3.1)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0, < 4.11)
webmock (3.20.0)
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
websocket (1.2.10)
webrick (1.8.1)
websocket-driver (0.7.6)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand All @@ -497,6 +500,7 @@ GEM
zeitwerk (2.6.13)

PLATFORMS
arm64-darwin-23
x86_64-linux

DEPENDENCIES
Expand All @@ -519,6 +523,7 @@ DEPENDENCIES
chartkick
countries
cssbundling-rails
cuprite
database_cleaner-active_record
devise
dotenv-rails
Expand Down Expand Up @@ -553,9 +558,9 @@ DEPENDENCIES
redis (~> 5.0)
ripper-tags
rspec-rails (~> 6.0, >= 6.0.3)
rspec-retry (~> 0.6.2)
rubocop
rubocop-shopify
selenium-webdriver
simplecov
simplecov-cobertura
solargraph
Expand All @@ -567,9 +572,8 @@ DEPENDENCIES
test-prof
tzinfo-data
web-console (>= 3.3.0)
webdrivers (>= 5.3.0)
webmock
zeitwerk

BUNDLED WITH
2.2.32
2.4.7
4 changes: 2 additions & 2 deletions gemfiles/rails_6.1_ruby_3.2.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ end

group :test do
gem "rspec-rails", "~> 6.0", ">= 6.0.3"
gem "rspec-retry", "~> 0.6.2"
gem "rails-controller-testing"
gem "capybara"
gem "selenium-webdriver"
gem "webdrivers", ">= 5.3.0"
gem "cuprite"
gem "fuubar"
gem "simplecov", require: false
gem "simplecov-cobertura"
Expand Down