Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple tippy renders #3285

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: multiple tippy renders #3285

merged 1 commit into from
Sep 30, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes a bug introduced here #3284

  • Removing the data-tippy attribute to prevent multiple tooltip renders on the same element.
  • Tagging the element with a has-data-tippy attribute to track the tooltip status.
  • Reverting the data-tippy attribute on turbo:before-cache event to ensure tooltips are properly reinitialized on page navigation (e.g., when the back button is pressed).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Sep 30, 2024
@Paul-Bob Paul-Bob added the Fix label Sep 30, 2024
Copy link

codeclimate bot commented Sep 30, 2024

Code Climate has analyzed commit 487e177 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 1f3f8cb into main Sep 30, 2024
22 of 23 checks passed
@Paul-Bob Paul-Bob deleted the fix/multiple_tippy_renders branch September 30, 2024 18:10
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@Paul-Bob Paul-Bob mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant