-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: fields Default Option #88
Conversation
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 96.33% 96.42% +0.09%
==========================================
Files 98 100 +2
Lines 2262 2348 +86
==========================================
+ Hits 2179 2264 +85
- Misses 83 84 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks, but pretty close to merge.
Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
Hey, let me know what you think about this. I also updated the table in Fields Usage (https://www.notion.so/3bf67c80933b4735bb20be3f1bcdef3e?v=f35ad1cd8d5046c8acb40d61be67af66).
PS: One test is not working and don't understand why, maybe we can look together into it. Already spend too much time on it.