Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: fields Default Option #88

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Conversation

mihaimdm22
Copy link
Contributor

Hey, let me know what you think about this. I also updated the table in Fields Usage (https://www.notion.so/3bf67c80933b4735bb20be3f1bcdef3e?v=f35ad1cd8d5046c8acb40d61be67af66).

PS: One test is not working and don't understand why, maybe we can look together into it. Already spend too much time on it.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #88 into master will increase coverage by 0.09%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   96.33%   96.42%   +0.09%     
==========================================
  Files          98      100       +2     
  Lines        2262     2348      +86     
==========================================
+ Hits         2179     2264      +85     
- Misses         83       84       +1     
Impacted Files Coverage Δ
spec/system/avocado/default_field_spec.rb 95.12% <95.12%> (ø)
lib/avocado/app/fields/field.rb 98.55% <100.00%> (+0.11%) ⬆️
lib/avocado/app/fields/hidden_field.rb 100.00% <100.00%> (ø)
spec/dummy/app/services/avocado/resources/team.rb 100.00% <100.00%> (ø)
.../app/services/avocado/resources/team_membership.rb 100.00% <100.00%> (ø)
spec/dummy/app/services/avocado/resources/user.rb 100.00% <100.00%> (ø)
spec/system/avocado/boolean_group_field_spec.rb 100.00% <0.00%> (ø)
...ec/dummy/app/services/avocado/resources/project.rb 100.00% <0.00%> (ø)
spec/system/avocado/select_field_spec.rb 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7645ca9...e1c4248. Read the comment docs.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, but pretty close to merge.

lib/avocado/app/fields/field.rb Outdated Show resolved Hide resolved
spec/system/avocado/default_field_spec.rb Outdated Show resolved Hide resolved
mihaimdm22 and others added 2 commits July 27, 2020 20:04
Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
@mihaimdm22 mihaimdm22 merged commit 4660f05 into master Jul 28, 2020
@mihaimdm22 mihaimdm22 deleted the feature/default-option-fields branch July 28, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants