Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: show actions on edit view #978

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Jun 20, 2022

Description

Fixes #977 and adds the actions on the Edit and New views.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Go to new user page
  2. Check that the ToggleAdmin action is visible
  3. No other actions will be visible on the New view
  4. The rest of the actions will be visible on all the other views Index, Edit, Show

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate
Copy link

codeclimate bot commented Jun 20, 2022

Code Climate has analyzed commit 806db55 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #978 (806db55) into main (7ba1100) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   93.75%   93.79%   +0.03%     
==========================================
  Files         478      479       +1     
  Lines        9227     9280      +53     
==========================================
+ Hits         8651     8704      +53     
  Misses        576      576              
Impacted Files Coverage Δ
app/components/avo/actions_component.rb 100.00% <100.00%> (ø)
...pp/components/avo/views/resource_edit_component.rb 96.55% <100.00%> (+0.12%) ⬆️
app/controllers/avo/base_controller.rb 95.19% <100.00%> (+0.04%) ⬆️
lib/avo/base_action.rb 78.50% <100.00%> (+0.20%) ⬆️
lib/avo/base_resource.rb 93.25% <100.00%> (+0.02%) ⬆️
lib/avo/concerns/has_model.rb 100.00% <100.00%> (ø)
spec/dummy/app/avo/actions/toggle_admin.rb 50.00% <100.00%> (+10.00%) ⬆️
spec/system/avo/actions_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba1100...806db55. Read the comment docs.

@adrianthedev adrianthedev merged commit d9f139a into main Jun 20, 2022
@adrianthedev adrianthedev deleted the feature/add-actions-to-the-edit-view branch June 20, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant see actions on edit
1 participant