Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest pressing "Enter" if a row is full #2

Closed
danirabbit opened this issue Jan 10, 2022 · 4 comments · Fixed by #16
Closed

Suggest pressing "Enter" if a row is full #2

danirabbit opened this issue Jan 10, 2022 · 4 comments · Fixed by #16
Labels
enhancement New feature or request

Comments

@danirabbit
Copy link

Is your feature request related to a problem? Please describe.

I'm a little slow, so I filled up a row and got "stuck" 😅 I read the directions but somehow it didn't click that I was meant to submit my answer once I'd filled up a row and not the full screen

Describe the solution you'd like

If a row is full, it would be nice to have some kind of on-screen suggestion or action to submit your answer

Describe alternatives you've considered

After a couple seconds you could throw a toast

I think what might be simplest though is fading in a button at the end of the row. go-jump is probably the most appropriate icon name for this (though it's a big ugly, sorry! I'll add that to my list of icons to fix up soon)

@avojak avojak added the enhancement New feature or request label Jan 11, 2022
@avojak
Copy link
Owner

avojak commented Jan 11, 2022

Ah this is good feedback - thanks! I hadn't considered this specific case, but I think it would also be good to provide a bit more feedback that users will be typing in the next blank row after submitting a guess. Perhaps some subtle background highlighting around the row for the guess currently being typed?

@avojak
Copy link
Owner

avojak commented Jan 12, 2022

Bumping into 1.2.0 so I can get 1.1.0 with an important bug fix

@avojak
Copy link
Owner

avojak commented Jan 21, 2022

I went around and around on this and I think I like the toast option the best. Fading in a button felt a bit clunky and didn't quite fit the look IMO. I also played around with wiggling the Enter button on the onscreen keyboard using a CSS animation, but that only affected the key image, but not the text.

The toast only pops once, ever, after 5 seconds if the user has filled the first row but not submitted a guess.

@avojak
Copy link
Owner

avojak commented Jan 21, 2022

Screenshot from 2022-01-20 18 01 01@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants