Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dark mode colors #20

Closed
mochaaP opened this issue Jan 24, 2022 · 2 comments
Closed

Improve dark mode colors #20

mochaaP opened this issue Jan 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mochaaP
Copy link

mochaaP commented Jan 24, 2022

Is your feature request related to a problem? Please describe.
Currently the playfield (both key and square) doesn't have a dark color when gtk_application_prefer_dark_theme is true, as illustrated below:

With custom stylesheet (Adapta-Nokto) With elementary stylesheet

This leads to an unpleasant high contrast when dark mode is activated.

Describe the solution you'd like
elementary OS screenshot

As other GTK/native elementary OS applications choose to use a darker color for inputs, a lighter color for buttons, we can also follow their behavior.

  • Squares should have a darker background than base (it's supposed to be deeper when considering a real-life game board)
  • Keys should have a brighter background than base

Describe alternatives you've considered
Use native GTK components and color with semantic color names (gdk_color_parse)

@avojak avojak added the enhancement New feature or request label Jan 25, 2022
@avojak avojak changed the title Respect dark mode colors Improve dark mode colors Jan 25, 2022
@avojak
Copy link
Owner

avojak commented Aug 12, 2022

Will be addressed as part of updating to GTK 4, which will use more CSS instead of very specific images for each tile state.

@avojak
Copy link
Owner

avojak commented Sep 2, 2022

Resolved with #39

@avojak avojak closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants