Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_string should quote special strings #39

Closed
favonia opened this issue Jun 21, 2020 · 0 comments · Fixed by #47
Closed

to_string should quote special strings #39

favonia opened this issue Jun 21, 2020 · 0 comments · Fixed by #47

Comments

@favonia
Copy link
Contributor

favonia commented Jun 21, 2020 •
edited
Loading

Currently, strings such as "true", "false", "null", "on", "1.0"... are not properly quoted when converted back to YAML scalars, and thus deserialization cannot recover these strings correctly.

I can make a PR to fix of_json, but it would conflict with PR #38, and thus I wish to learn the fate of that PR first.
@favonia favonia changed the title to_json is not a left inverse of of_json to_string should quote special strings Jun 28, 2020
@favonia favonia mentioned this issue Jun 28, 2020
Closed
@avsm avsm mentioned this issue Aug 4, 2021
Merged
@avsm avsm closed this as completed in #47 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Yaml.to_string x |> Yaml.of_string resulting in different values avsm/ocaml-yaml
1 participant
@favonia