-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending the media modal? #249
Comments
According to MDN the 'align' attribute has been deprecated for images. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#align I recommend inserting the image then using the alignment tools from the toolbar. |
Hi @awcodes, I wasn't trying to use the align attribute per se; I just wanted to be able to add a custom class to the image. Is that something that can be done? |
Ah. ok. i'll reopen then. |
Many time after this, I'm back. It'd be great to be able to add more params. filament-tiptap-editor/resources/js/plugin.js:465
Here there's a list of all possible attributes:
and of course, some global attributes as:
and some event handlers:
Adding all those to |
I'm open to PRs. Haven't forgotten about the original issue. Just haven't had the time. Sorry. |
The plugin is awesome. Let me first of all thank you for it. I've already made a PR with those properties needed for responsive images coming from spatie/laravel-medialibrary |
I'll look at the PR when I get a chance. Thank you. |
Filament Version
v3.0.97
Plugin Version
v3.2.6
PHP Version
PHP 8.2
Problem description
Following up on this discussion: I'm trying to extend the existing MediaAction to allow for an "align" attribute.
Here's my custom MediaAction (which doesn't work)
Expected behavior
When you insert an image, the "align" attribute should be added to the img tag, like so tag.
Steps to reproduce
N/A
Reproduction repository
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: