Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline images not working in thunderbird? #142

Closed
philpagel opened this issue May 6, 2022 · 5 comments · Fixed by #144
Closed

Inline images not working in thunderbird? #142

philpagel opened this issue May 6, 2022 · 5 comments · Fixed by #144
Labels

Comments

@philpagel
Copy link

philpagel commented May 6, 2022

I am trying to use an inline image as described in the readme.md and at first sight it is working, but not consistently for different mail readers.

Here is my template:

To: {{email}}
Subject: Hi
From: Foo Bar <foo.bar@xxx.com>
Attachment: logo.png
Content-Type: text/markdown

{{salutation}} {{title}} {{lastname}},

Some email text.

Best regards
     me

-- 
Me 
jobtitle

![Company logo](logo.png)

I sent this to myself (different accounts), first and opened it in different mail readers. To my surprise they differ with respect to the result:

  • gmail web: image is shown
  • thunderbird: Image is not shown inline
  • Webmail (t-online): image is shown inline

Of course, this seems to indicate a problem at the end of the mail reader but then Thunderbird is pretty widespread so I was wondering if there is something I am getting wrong or if this could even be a bug. Of course, I checked and "Display attachments inline" is checked in thunderbird.

Any hints or insights are highly welcome.

Thanks Phil

@awdeorio
Copy link
Owner

awdeorio commented May 6, 2022

Thanks for taking the time to report, Phil. I wonder if an HTML change suggested by this SO post would fix the issue? The post suggests using Content Type multipart/related instead of multipart/mixed.

Tagging @seshrs for his opinion.

@philpagel
Copy link
Author

Thanks for the link! I'll play with that and report on the result.

@philpagel
Copy link
Author

Sorry for the delay, I was pretty busy during the week. But today I found some time to further play with this.
I went and edited Thunderbirds mbox file changing multipart/mixed to multipart/related for the message in question and, lo an behold, the inline image is now correctly displayed in thunderbird.

@awdeorio awdeorio added the bug label May 16, 2022
@awdeorio
Copy link
Owner

Thanks @philpagel this is really helpful. Let me know if you feel up to trying a fix. I think it might be a one-line change.

@philpagel
Copy link
Author

Sounds easy enough – I'll fork look into it and get back with a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants