Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a solid border a precondition for a valid environmental map #3

Open
aweisser opened this issue Jun 11, 2017 · 1 comment
Open

Comments

@aweisser
Copy link
Owner

aweisser commented Jun 11, 2017

As @irgndsondepp stated the out of bounds checks previously worked by accident because there is always a solid wall in every direction.

We should make a solid border (without gaps) a precondition for a valid environmental map.

@rluetzner
Copy link
Collaborator

Do you suggest to check every environmental map, or would you rather just say everything outside the map array is solid?

What I meant by my comment was that in the test instead of the robot starting in front of a wall, the robot was already inside the wall and tried moving out of the array. So it still couldn't move but the initial position was invalid.

I like the way maps are created and displayed in unit tests and to keep it humanly readable I second adding a check for solid boundaries.

I also added #4 concerning the robot's starting position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants