Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worth-reading CSS books #115

Closed
jaykay12 opened this issue Oct 5, 2017 · 8 comments
Closed

Add worth-reading CSS books #115

jaykay12 opened this issue Oct 5, 2017 · 8 comments

Comments

@jaykay12
Copy link
Contributor

jaykay12 commented Oct 5, 2017

Apparently, Some people like reading books more than watching videos, So, I propose to add few names of good reference books for learning CSS as currently this particular aspect is missing in the Awesome CSS. 😊

@jaykay12
Copy link
Contributor Author

jaykay12 commented Oct 5, 2017

@Rishabh04-02 Wasn't my PR Fair enough to serve the purpose? Later on, with course of time enhancements could have been done 😞

@Rishabh04-02
Copy link
Member

@jaykay12 I've requested the maintainers that we need a discussions platform, once they respond to it then we can have a discussions there regarding the issues, queries and the development of awesome-css.

@sotayamashita
Copy link
Collaborator

@jaykay12 We are sorry to feel bad. Recently I have invited members but I do not have rules.

@Rishabh04-02 What about to create rules for maintainers and first rules will be "We need 2 people approval when we merge PRs" What do you think?

@Rishabh04-02
Copy link
Member

@sotayamashita This 2 people rule is good 👍 , i agree with it.

@jaykay12
Copy link
Contributor Author

jaykay12 commented Oct 6, 2017

@sotayamashita Its totally cool man!
But yeah, #116 was closed as it was containing books that were published around 5-7 years, so will it be nice if I add a Book section in the Awesome CSS with 1 or 2 popular books only & later on substantial additions to it can be done by other contributors as well. 😄

@Rishabh04-02 what do you say?

@troxler
Copy link
Contributor

troxler commented Oct 6, 2017

Sorry if my comments in the pull request seem harsh.

I'm not sure whether it is better to require two approvals as it also means double the work. In my opinion it is enough to ping other contributors to comment if a pull request is controversial. If a request is closed or merged, you can always step into the discussion (and reopen the request) if you disagree.


so will it be nice if I add a Book section in the Awesome CSS with 1 or 2 popular books only

@jaykay12 sure.

@jaykay12 jaykay12 changed the title Add a list of decent books Add worth-reading CSS books Oct 7, 2017
@stale
Copy link

stale bot commented Dec 11, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 11, 2017
@stale
Copy link

stale bot commented Feb 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants