-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(question/request) Get menubar table #1365
Comments
Hello, I started a multi phase refactor of the menubar (#1329 for phase 1 and there is a gist with phase 2 WIP code). I will probably take care of it in the last PR of that series. For now, you can copycat my version https://github.com/Elv13/awesome-configs/blob/master/utils/fd_async.lua (demo menu https://github.com/Elv13/awesome-configs/blob/master/customMenu/appmenu.lua). It has:
|
So, run that code in the callback instead of before it?
I do not think anything that was provided is lost, is it? The only "problem" might be that awesome no longer freezes while it loads all the menu files, meaning your code has to wait for a callback. |
Already tried both, the result is the same:
Of course nothing is lost, but still the menu is no longer allowed. The point is waiting for the callback: how can we synchronize? This is the real problem. I can only think about sockets, but in Lua it'd require a clever design. @Elv13 Your work is always impressive, but radical is simply huge and it's hard to figure out how to switch to |
With @BlueUsername 's patch, my little repo got back on track, even though now I am forced to return an |
@copycat-killer Can this be closed? |
Git shows the request has been satisfied, so yeah. Thanks. |
In the previous 3.5.x branch,
menubar.menu_gen.generate
returns anawful.menu
compliant table, while in the 4.0 branch it doesn't anymore.Can you tell me a clean way to get the same result in current branch too?
This is the best I could do, but it's dirty: this part doesn't work because of the asynchronicity of
menu_gen.generate
, which terminates after it.Since the original Freedesktop module was meant to provide a menu, it'd be nice to have this feature back.
The text was updated successfully, but these errors were encountered: