Skip to content

Commit

Permalink
fix: update ncc and minor workflow enhancements (#269)
Browse files Browse the repository at this point in the history
* updated deprecated ncc version and added nodejs 18 to github workflows

* corrected package ncc and added lock file

---------

Co-authored-by: Sapeksh Madan <sapmadan@amazon.com>
  • Loading branch information
sapekshm and sapeksh-madan-scf-guest committed Oct 4, 2023
1 parent 1e00aa6 commit 3e9a743
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 17 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,23 @@ name: Check
jobs:
check:
name: Run Unit Tests
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v2
#Version actions/checkout@V3.6.0
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
- name: Node setup
#Version actions/setup-node@v3.8.1
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
with:
node-version: "18.16.1"
- name: Run tests
run: |
npm ci
npm test
conventional-commits:
name: Semantic Pull Request
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: validate
uses: actions/github-script@v6
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,18 @@ name: Package
jobs:
check:
name: Package distribution file
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v2
#Version actions/checkout@V3.6.0
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
with:
ref: master
- name: Node setup
#Version actions/setup-node@v3.8.1
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d
with:
node-version: "18.16.1"
- name: Package
run: |
npm ci
Expand Down
19 changes: 9 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"tmp": "^0.2.1"
},
"devDependencies": {
"@zeit/ncc": "^0.22.3",
"@vercel/ncc": "^0.38.0",
"eslint": "^8.50.0",
"jest": "^29.7.0"
}
Expand Down

0 comments on commit 3e9a743

Please sign in to comment.