-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): Ignore ApiAuthExceptions when subscribing or syncing models #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2561 +/- ##
==========================================
+ Coverage 41.16% 41.43% +0.26%
==========================================
Files 874 874
Lines 27635 27644 +9
Branches 3880 3883 +3
==========================================
+ Hits 11375 11453 +78
+ Misses 15039 14962 -77
- Partials 1221 1229 +8 |
mattcreaser
force-pushed
the
mattcreaser/multiauth-start
branch
from
August 18, 2023 15:17
f6d4899
to
ccbfe28
Compare
mattcreaser
force-pushed
the
mattcreaser/multiauth-start
branch
from
August 18, 2023 17:22
9258b5e
to
534ab1d
Compare
This PR fixes #1394 as well |
gpanshu
approved these changes
Aug 22, 2023
tylerjroach
approved these changes
Aug 23, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2399
Description of changes:
ApiAuthException
fromMultiAuthSubscriptionOperation
if authTypes are exhausted when trying to establish a subscription (this is already how the multi-auth sync worked, and appeared to be the intended implementation based on existing code comments).ApiAuthException
encountered when starting theSubscriptionProcessor
and theSyncProcessor
. This effectively skips those models and allows syncing/subscribing to continue for other models.How did you test these changes?
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.