-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datastore): Temporary workaround to stabilize DataStore test. #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjroach
changed the title
Temporary workaround to stabilize DataStore test.
fix(datastore): Temporary workaround to stabilize DataStore test.
Oct 25, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #2618 +/- ##
=======================================
Coverage 41.71% 41.72%
=======================================
Files 900 900
Lines 28852 28870 +18
Branches 4098 4105 +7
=======================================
+ Hits 12037 12045 +8
- Misses 15491 15496 +5
- Partials 1324 1329 +5 |
gpanshu
reviewed
Oct 25, 2023
aws-datastore/src/androidTest/java/com/amplifyframework/datastore/DataStoreHubEventFilters.java
Show resolved
Hide resolved
gpanshu
previously approved these changes
Oct 25, 2023
…tion' into tjroach/datastore-test-stabilization
gpanshu
previously approved these changes
Oct 25, 2023
ankpshah
approved these changes
Oct 25, 2023
gpanshu
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2617
Description of changes:
DataStore has a bug on
clear
that can cause crashes in some situations. While it is a race condition that is hard to replicate, the above explains the cause.The root of the issue needs fixed and can happen in production. While waiting for the correct fix, this PR should at least stabilize a
delete
test that has other valid purposes is its testing, and is important to not ignore, while waiting on a fix.How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.