Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): Temporary workaround to stabilize DataStore test. #2618

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2617

Description of changes:
DataStore has a bug on clear that can cause crashes in some situations. While it is a race condition that is hard to replicate, the above explains the cause.

The root of the issue needs fixed and can happen in production. While waiting for the correct fix, this PR should at least stabilize a delete test that has other valid purposes is its testing, and is important to not ignore, while waiting on a fix.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested a review from a team as a code owner October 25, 2023 16:58
@tylerjroach tylerjroach changed the title Temporary workaround to stabilize DataStore test. fix(datastore): Temporary workaround to stabilize DataStore test. Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #2618 (a0ddb0d) into main (e273ba8) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 32.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #2618   +/-   ##
=======================================
  Coverage   41.71%   41.72%           
=======================================
  Files         900      900           
  Lines       28852    28870   +18     
  Branches     4098     4105    +7     
=======================================
+ Hits        12037    12045    +8     
- Misses      15491    15496    +5     
- Partials     1324     1329    +5     

gpanshu
gpanshu previously approved these changes Oct 25, 2023
gpanshu
gpanshu previously approved these changes Oct 25, 2023
@tylerjroach tylerjroach enabled auto-merge (squash) October 25, 2023 18:59
@tylerjroach tylerjroach merged commit b67ec35 into main Oct 25, 2023
7 checks passed
@tylerjroach tylerjroach deleted the tjroach/datastore-test-stabilization branch October 25, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants