-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable eslint rules to enforce type import/export style #709
enable eslint rules to enforce type import/export style #709
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can help prevent errors such as https://typescript.tv/errors/#ts2742
"Can help prevent" or "does prevent"? Do we have a consistent repro where doing this solves the issue?
@edwardfoyle I was looking up the original errors I was getting and came across this thread where explicitly using not sure if this has something to do with it:
I can try resolving these conflicts and linking this to my existing project to see if it gets rid of the type errors |
Issue #, if available:
Description of changes:
Enforces consistent type imports and exports. This can help prevent errors such as https://typescript.tv/errors/#ts2742 when consuming the libraries with pnpm or npm's "linked" install strategy.
Enabling this emits 504 errors from ESLint
Questions:
import type
)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.