chore: 馃 add support for ap-northeast-3 KIX #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables support in ap-northeast-3 region(KIX)
dpilch
previously approved these changes
Jul 31, 2023
AaronZyLee
requested changes
Jul 31, 2023
| @@ -27,6 +27,7 @@ export const amplifyRegions = [ | |||
| 'eu-central-1', | |||
| 'ap-northeast-1', | |||
| 'ap-northeast-2', | |||
| 'ap-northeast-3', | |||
There was a problem hiding this comment.
I think this change should be excluded until the CLI has released the region option in amplify configure. Otherwise it could cause the API e2e test failure. (I am testing with latest version 12.2.3 and do not find the new region).
There was a problem hiding this comment.
Removed in the last revision.
dpilch
approved these changes
Aug 1, 2023
AaronZyLee
approved these changes
Aug 1, 2023
This was referenced Jul 31, 2023
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR enables support in ap-northeast-3 region (KIX)
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
Associated CLI PR: aws-amplify/amplify-cli#13039
Description of how you validated changes
I set ap-northeast-3 in my ~/.aws/config for my amplify profile and created an app.
I ran:
amplify-dev init
amplify-dev add api (default graphQL options)
amplify-dev push
Confirmed that an API was successfully deployed to my account in ap-northeast-3 region
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.