Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Liveness: Support clock skew greater than 5 minutes #5124

Closed
2 tasks
esauerbo opened this issue Apr 2, 2024 · 5 comments · Fixed by #5344
Closed
2 tasks

[FR] Liveness: Support clock skew greater than 5 minutes #5124

esauerbo opened this issue Apr 2, 2024 · 5 comments · Fixed by #5344
Labels
feature-request Request a new feature Liveness

Comments

@esauerbo
Copy link
Contributor

esauerbo commented Apr 2, 2024

On which framework/platform would you like to see this feature implemented?

React

Which UI component is this feature-request for?

Liveness

Please describe your feature-request in detail.

Users in some countries such as Brazil and Egypt use Android phones which have not been updated to the correct time zone, and thus are off by one hour. This results in a failed check with the below error

{
state: SERVER_ERROR
error: { "Message": Signature Expired ... }
}

We currently only support clock skew under 5 minutes, so the request is to support more than 5 minutes.
#4386 (comment)

Please describe a solution you'd like.

No response

We love contributors! Is this something you'd be interested in working on?

  • 👋 I may be able to implement this feature request.
  • ⚠️ This feature might incur a breaking change.
@esauerbo esauerbo added the feature-request Request a new feature label Apr 2, 2024
@github-actions github-actions bot added the pending-triage Issue is pending triage label Apr 2, 2024
@esauerbo esauerbo added Liveness and removed pending-triage Issue is pending triage labels Apr 2, 2024
@marcosconceicao
Copy link

👍🏾 We are facing the same issue in BR, people from Amazonas (GMT -4), Acre (GMT -5), and other states that are not GMT -3, using phones that don't register correctly timezones cannot use liveness.

@reesscot
Copy link
Contributor

@marcosconceicao We are researching this issues and have some questions. Can you give an example of how the devices with issues are set? From our testing it seems like users will encounter this issue when they have manually changed their clocks to a different time without changing the time zone, or we've also found that this can happen on older android devices which are still showing daylight savings time in Brazil time zones. Is this the scenario you are facing? Any further details you can provide would be very helpful.

@anahiforesi
Copy link

Hi team.
Do we have any update on this issue?

@esauerbo
Copy link
Contributor Author

@anahiforesi This is something we're actively working on but I can't give a specific timeline for release at the moment.

@esauerbo
Copy link
Contributor Author

esauerbo commented Jul 2, 2024

A fix for this has been released in @aws-amplify/ui-react-liveness@latest!

You can now optionally pass a value for systemClockOffset into the FaceLivenessDetectorCore config, where it will be added as an offset to the AWS server time. (e.g. if the device is one hour ahead of server time, you would pas -3600000, which is 1 hour in milliseconds)

<FaceLivenessDetectorCore
  ...
  config={{
    systemClockOffset={createLivenessApiData.systemClockOffset}
  }}
/>

You as the developer are responsible for calculating this value and you can find an example in our documentation. You can test your implementation locally by changing your device time while keeping the time zone the same.

If you have any questions, please open a new GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature Liveness
Projects
None yet
4 participants