Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@opentelemetry/api" should be a peer dependency for Xray Propagator #56

Closed
kbkk opened this issue Apr 28, 2021 · 4 comments
Closed

"@opentelemetry/api" should be a peer dependency for Xray Propagator #56

kbkk opened this issue Apr 28, 2021 · 4 comments

Comments

@kbkk
Copy link

kbkk commented Apr 28, 2021

Hi,

Right now, the Xray Propagator (@aws/otel-aws-xray-propagator) does not work with @opentelemetry/api (API) other than 0.13.0. The reason for that is, it installs its own version of the API and therefore ignores any configuration set by the developer.

If you look at official Otel packages, those treat the API as a peerDependency, e.g.:
https://github.com/open-telemetry/opentelemetry-js/blob/b9c842613c4439435f1644c8c8e288d1fd0e384c/packages/opentelemetry-propagator-jaeger/package.json#L75

@anuraaga
Copy link
Contributor

Hi @kbkk - we've just completed migrating this package upstream so a newer version is available there!

https://www.npmjs.com/package/@opentelemetry/propagator-aws-xray

The packages in this repo are deprecated and we'll be removing them soom, please check out that package. Thanks.

@kbkk
Copy link
Author

kbkk commented Apr 28, 2021

Awesome, looks like that is working! Thanks

If I may suggest, please mark @aws/otel-aws-xray-propagator as deprecated on npm - it'll save a lot of trouble for Otel newcomers.

Feel free to close the issue.

@anuraaga
Copy link
Contributor

@alolita Can you mark these two packages deprecated on NPM?

@PaurushGarg
Copy link
Member

Closing Issue as the package has been marked deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants