Chore: Add documentation for confmap providers and Kafka receiver and exporter #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
rapphil
changed the title
mhausenblas
requested changes
Mar 30, 2023
There was a problem hiding this comment.
Overall LGTM, thanks @rapphil! Couple of comments inline and please make sure to consistently name things, for example it should be ADOT collector (lower case) all the places.
Signed-off-by: Raphael Silva <rapphil@gmail.com>
mhausenblas
approved these changes
Apr 5, 2023
|
Please do not release. @bryan-aguilar should be the one releasing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for confmap providers and Kafka receiver and exporter.
IMPORTANT: Please do not merge yet.