Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused return value of listExports method in ListJournalExports #8

Closed
ChrisJBurns opened this issue Apr 11, 2020 · 0 comments · Fixed by #108
Closed

Unused return value of listExports method in ListJournalExports #8

ChrisJBurns opened this issue Apr 11, 2020 · 0 comments · Fixed by #108

Comments

@ChrisJBurns
Copy link

In ListJournalExports there three overloaded listExports functions, issue #7 addresses removing the 2 unused ones.

This issue will focus more on removing the need to return a value from the one used listExports function.

I suggest just replacing the return List<JournalS3ExportDescription> with void and keeping the printing of the exports within the listExports method.

Can do in a quick PR if agreed to address.

C
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ChrisJBurns