Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All java examples should have upgrade of aws and junit dependencides #749

Closed
nagkumar opened this issue Sep 27, 2022 · 2 comments
Closed
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@nagkumar
Copy link

Describe the bug

legacy dependencies are used in examples, upgrade is the need

Expected Behavior

All examples should work on latest CDK versions

Current Behavior

the current dependencides are

software.amazon.awscdk aws-cdk-lib [2.0.0,)
    <dependency>
        <groupId>software.constructs</groupId>
        <artifactId>constructs</artifactId>
        <version>[10.0.0,)</version>
    </dependency>

    <!-- https://mvnrepository.com/artifact/junit/junit -->
    <dependency>
        <groupId>junit</groupId>
        <artifactId>junit</artifactId>
        <version>4.13.1</version>
        <scope>test</scope>
    </dependency>
</dependencies>

Reproduction Steps

check each pom.xml

Possible Solution

mvn versions:use-latest-versions

run above command to auto upgrade all the dependencies
the

Additional Information/Context

software.amazon.awscdk aws-cdk-lib 2.43.1
<dependency>
    <groupId>software.constructs</groupId>
    <artifactId>constructs</artifactId>
    <version>10.1.114</version>
</dependency>

<dependency>
    <groupId>junit</groupId>
    <artifactId>junit</artifactId>
    <version>4.13.2</version>
    <scope>test</scope>
</dependency>
</dependencies>

CDK CLI Version

2.43.1 (build c1ebb85)

Framework Version

No response

Node.js Version

18

OS

win10

Language

Java

Language Version

18

@nagkumar nagkumar added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 27, 2022
@nagkumar nagkumar changed the title All java examples should have upgrade of dependencides All java examples should have upgrade of aws and junit dependencides Sep 27, 2022
@saikatak
Copy link

All of the project has version with expression [v.v.v,) where v.v.v is the minimum required version and using this expression in pom automatically picks up the latest version of that particular library.

@kaiz-io kaiz-io closed this as completed Mar 30, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants