Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Async call after Google authentication #1

Closed
KoldBrewEd opened this issue Jun 8, 2017 · 3 comments
Closed

Async call after Google authentication #1

KoldBrewEd opened this issue Jun 8, 2017 · 3 comments

Comments

@KoldBrewEd
Copy link
Contributor

Sometimes the async call to get the temporary credentials from Cognito after the Google authentication does not return the credentials and it requires to authenticate a second time. Working on a better callback strategy.

@markdernie
Copy link
Contributor

Thanks for putting this together it was very useful. I also had the problem with the google authentication but it wasn't intermittent. I think the issue is that the google authentication is called from a different component (google-signin) from the testgoogle function (app). This means that the googlecallback is called in google-signin not app so the loggedInCreds doesn't get set in app. I added this.awsService.getgoogleData(this); to the testGoogle function to force the local googleCallback to be called, and it seems to work now. Thanks again for putting the example together it was an really big help in my understanding of this area.

@KoldBrewEd
Copy link
Contributor Author

Thanks for that! Would you mind creating a pull request with your fix? It'd be very helpful, I'll get it merged straight away

@KoldBrewEd
Copy link
Contributor Author

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants