Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options to hook #14

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add config options to hook #14

merged 1 commit into from
Jul 18, 2022

Conversation

Pellizzon
Copy link
Contributor

@Pellizzon Pellizzon commented Jul 14, 2022

Description of changes:

Add more template field options to EmrServerlessStartJobOperator
Add **kwargs on emr serverless hook to be able to correctly pass config parameters from operator to hook

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…s to hook.start_serverless_job so it's now possible to pass extra parameters to the job run (eg.:name & executionTimeoutMinutes)
@Pellizzon
Copy link
Contributor Author

@dacort can you take a look at this?

@dacort
Copy link
Contributor

dacort commented Jul 18, 2022

Ah yep, sorry hadn't realized I forgot to check in my changes in hook.

@dacort
Copy link
Contributor

dacort commented Jul 18, 2022

Looks good to me - will merge today and create an updated release.

@dacort dacort merged commit d56ac2e into aws-samples:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for name and tags in EmrServerlessStartJobOperator
2 participants