Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Running "make deb" or "make generic-rpm" does not package amazon-ecs-volume-plugin #431

Closed
dennisconrad opened this issue Jul 21, 2021 · 2 comments

Comments

@dennisconrad
Copy link
Contributor

dennisconrad commented Jul 21, 2021

Summary

Running make deb or make generic-rpm does not package the amazon-ecs-volume-plugin.

NB: make generic-rpm was not working at all on Red Hat Enterprise Linux 8.4; this PR fixes this as well.

Description

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package does not include the amazon-ecs-volume-plugin binary and startup scripts.

Expected Behavior

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package should include the amazon-ecs-volume-plugin binary and startup scripts.

Observed Behavior

When building a generic Debian package via make deb or a generic RPM package via make generic-rpm, the resulting package does not include the amazon-ecs-volume-plugin binary and startup scripts.

Environment Details

Ubuntu 18.04 Bionic
Red Hat Enterprise Linux 8.4

@dennisconrad
Copy link
Contributor Author

dennisconrad commented Jul 21, 2021

Fixed by: #432 #433

@dennisconrad dennisconrad changed the title make deb does not package amazon-ecs-volume-plugin Running "make deb" or "make generic-rpm" does not package amazon-ecs-volume-plugin Jul 23, 2021
@Realmonia
Copy link
Contributor

PR is merged. Close this issue. Thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants