Update dependency versions #129
Conversation
RedbackThomson
force-pushed
the
controller-gen-update
branch
from
3f3d26c
to
467d22d
Compare
| @@ -56,7 +56,7 @@ type BatchTransformJobSpec struct { | |||
| Region *string `json:"region"` | |||
|
|
|||
| // A custom SageMaker endpoint to use when communicating with SageMaker. | |||
| // +kubebuilder:validation:Pattern=^(https|http)://.*$ | |||
| // +kubebuilder:validation:Pattern="^(https|http)://.*$" | |||
There was a problem hiding this comment.
Were you able to verify that was actually a version mismatch issue ?
There was a problem hiding this comment.
Yes. This error was exactly as predicted.
| @@ -14,3 +12,5 @@ images: | |||
| newTag: v1 | |||
| resources: | |||
| - ../manager | |||
| patchesStrategicMerge: | |||
| - manager_auth_proxy_patch.yaml | |||
There was a problem hiding this comment.
This actually comes from @akartsky 's latest changes. I switched the order of his make targets so that it runs the US target last, that way all of our Kustomize templates have the US implementation as the default when checked in.
|
We should probably call out these versions in the docs or atleast the READMEs too |
These versions are specified in the |
I guess that's true. If someone is developing on top of these operators they would be familiar enough with golang to know where to look. |
What does this PR do / how does this improve the operators?
Updates the following Go dependencies:
controller-gen:v0.2.0-beta.2->v0.3.0aws-sdk-go-v2:v0.20.0->v0.24.0controller-runtime:v0.2.0->v0.6.1client-go:v11.0.1-#->v0.18.6Which issue(s) does this PR fix?
Fixes #125
Special notes for the reviewer:
Had to make a small change to each of the
suite_test.gofiles (in/api/*and/controllers/*) because theNewLineReportermoved to theenvtest/printerdirectory. Also had to create a new unit test helper methodCreateMockNamespacewhich creates a namespace within the mock API server. It seems that the newer version of thecontroller-runtimerequire the namespace be created before attempting to use it. Allmaketargets work properly.Does this PR require changes to documentation?
No
All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.