This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Remove enable-leader-election as default #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
approved these changes
May 18, 2021
mbaijal
approved these changes
May 21, 2021
surajkota
pushed a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this PR fix?
ERROR setup unable to start manager {"error": "LeaderElectionID must be configured"}For China region
--enable-leader-electionwas set by default.Looks like that feature is broken and further investigation is required.
For now remove that argument from default
Testing
All the files are auto generated and tested locally.
Note to reviewers
Our
1.1.0release was withcontroller-runtimeversionv0.2.0in Aug 2020 we updated the version to 0.6.1 : #129
in Sep 2020 we updated the version to 0.6.2 : #139
Our
1.2.0release was withcontroller-runtimeversionv0.6.2I verified that the 1.1.0 image works fine with
--enable-leader-electionin China regionThis version update seems to be the root cause and we need to change our main.go function to fix manager creation with new options
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.