Skip to content

Commit

Permalink
fix(cloudfront): Distribution ignores webAclId (#9828)
Browse files Browse the repository at this point in the history
This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
njlynch committed Aug 19, 2020
1 parent 73f77e9 commit 366c781
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/@aws-cdk/aws-cloudfront/lib/distribution.ts
Expand Up @@ -284,6 +284,7 @@ export class Distribution extends Resource implements IDistribution {
priceClass: props.priceClass ?? undefined,
restrictions: this.renderRestrictions(props.geoRestriction),
viewerCertificate: this.certificate ? this.renderViewerCertificate(this.certificate) : undefined,
webAclId: props.webAclId,
},
});

Expand Down
1 change: 1 addition & 0 deletions packages/@aws-cdk/aws-cloudfront/test/distribution.test.ts
Expand Up @@ -100,6 +100,7 @@ test('exhaustive example of props renders correctly', () => {
SslSupportMethod: 'sni-only',
MinimumProtocolVersion: 'TLSv1.2_2019',
},
WebACLId: '473e64fd-f30b-4765-81a0-62ad96dd167a',
},
});
});
Expand Down

0 comments on commit 366c781

Please sign in to comment.