Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-cloudfront] cloudfront.Distribution ignores webAclId #9824

Closed
lanwen opened this issue Aug 19, 2020 · 1 comment · Fixed by #9828
Closed

[aws-cloudfront] cloudfront.Distribution ignores webAclId #9824

lanwen opened this issue Aug 19, 2020 · 1 comment · Fixed by #9828
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@lanwen
Copy link
Contributor

lanwen commented Aug 19, 2020 •
edited

DistributionProps.webAclId has no effect when used with cloudfront.Distribution and I cant actually find any usage in js files, only in types

Reproduction Steps

new cloudfront.Distribution(
      this,
      "StaticDistribution",
      {
        defaultBehavior: {
          origin: new origins.S3Origin(bucket),
        },
        webAclId: wafAclArn,
      }
    );

What did you expect to happen?

DistributionConfig.WebACLId would be in the generated template

What actually happened?

Nothing

Environment

  • CLI Version : 1.59
  • Framework Version: 1.59

Other

right now workarounded with

    const cfnDistro = distribution.node
      .defaultChild as cloudfront.CfnDistribution;
    cfnDistro.addPropertyOverride("DistributionConfig.WebACLId", wafAclArn);

This is 🐛 Bug Report
@lanwen lanwen added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 19, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Aug 19, 2020
@iliapolo iliapolo assigned njlynch and unassigned iliapolo Aug 19, 2020
@njlynch njlynch added p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 19, 2020
@njlynch
Copy link
Contributor

njlynch commented Aug 19, 2020

Whoops. This got missed in #9635.

njlynch added a commit that referenced this issue Aug 19, 2020
@njlynch
fix(cloudfront): Distribution ignores webAclId
fdfac7f 
This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824
@njlynch njlynch mentioned this issue Aug 19, 2020
Merged
@njlynch njlynch added the in-progress This issue is being actively worked on. label Aug 19, 2020
@mergify mergify bot closed this as completed in #9828 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@njlynch
fix(cloudfront): Distribution ignores webAclId (#9828)
366c781 
This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloudfront): Distribution ignores webAclId aws/aws-cdk
3 participants
@njlynch @iliapolo @lanwen