Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): Distribution ignores webAclId #9828

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 19, 2020

This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824
@njlynch njlynch added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Aug 19, 2020
@njlynch njlynch requested a review from a team August 19, 2020 11:02
@njlynch njlynch self-assigned this Aug 19, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 19, 2020
@nija-at nija-at changed the title fix(cloudfront): Distribution ignores webAclId fix(cloudfront): distribution ignores webAclId Aug 19, 2020
@nija-at nija-at changed the title fix(cloudfront): distribution ignores webAclId fix(cloudfront): Distribution ignores webAclId Aug 19, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cfae9bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 366c781 into master Aug 19, 2020
@mergify mergify bot deleted the njlynch/cf-web-acl branch August 19, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-cloudfront] cloudfront.Distribution ignores webAclId
4 participants