-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: migrate aws-cdk from nodeunit to jest (#5659)
There is some interesting magic happening around the runtime-info module: `jest` replaces the standard `require` function so it can honor module mocking requirements, however this does (intentionally) not implement `require.cache`, which is used to determine which CDK libraries are loaded during a particular execution (in order to populate the `AWS::CDK::Metadata` resource as needed). In order to work around this, the `require.cache` reading was indirected through a proxy module, so it can be stubbed, too, with a pretend cache content, in order to make the test still workable.
- Loading branch information
1 parent
1085a27
commit 59cbdc0
Showing
56 changed files
with
2,714 additions
and
3,056 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,6 @@ cdk.context.json | |
| .cdk.staging/ | ||
| cdk.out/ | ||
| *.tabl.json | ||
|
|
||
| # Yarn error log | ||
| yarn-error.log | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import * as fs from 'fs-extra'; | ||
| import * as path from 'path'; | ||
| import { AccountAccessKeyCache } from '../lib/api/util/account-cache'; | ||
|
|
||
| async function makeCache() { | ||
| const dir = await fs.mkdtemp('/tmp/account-cache-test'); | ||
| const file = path.join(dir, 'cache.json'); | ||
| return { | ||
| cacheDir: dir, | ||
| cacheFile: file, | ||
| cache: new AccountAccessKeyCache(file), | ||
| }; | ||
| } | ||
|
|
||
| async function nukeCache(cacheDir: string) { | ||
| await fs.remove(cacheDir); | ||
| } | ||
|
|
||
| test('get(k) when cache is empty', async () => { | ||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
| try { | ||
| expect(await cache.get('foo')).toBeUndefined(); | ||
| expect(await fs.pathExists(cacheFile)).toBeFalsy(); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test('put(k,v) and then get(k)', async () => { | ||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| await cache.put('key', 'value'); | ||
| await cache.put('boo', 'bar'); | ||
| expect(await cache.get('key')).toBe('value'); | ||
|
|
||
| // create another cache instance on the same file, should still work | ||
| const cache2 = new AccountAccessKeyCache(cacheFile); | ||
| expect(await cache2.get('boo')).toBe('bar'); | ||
|
|
||
| // whitebox: read the file | ||
| expect(await fs.readJson(cacheFile)).toEqual({ | ||
| key: 'value', | ||
| boo: 'bar' | ||
| }); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test('fetch(k, resolver) can be used to "atomically" get + resolve + put', async () => { | ||
| const { cacheDir, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| expect(await cache.get('foo')).toBeUndefined(); | ||
| expect(await cache.fetch('foo', async () => 'bar')).toBe('bar'); | ||
| expect(await cache.get('foo')).toBe('bar'); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test(`cache is nuked if it exceeds ${AccountAccessKeyCache.MAX_ENTRIES} entries`, async () => { | ||
| // This makes a lot of promises, so it can queue for a while... | ||
| jest.setTimeout(30_000); | ||
|
|
||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| await cache.put(`key${i}`, `value${i}`); | ||
| } | ||
|
|
||
| // verify all values are on disk | ||
| const otherCache = new AccountAccessKeyCache(cacheFile); | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| expect(await otherCache.get(`key${i}`)).toBe(`value${i}`); | ||
| } | ||
|
|
||
| // add another value | ||
| await cache.put('nuke-me', 'genesis'); | ||
|
|
||
| // now, we expect only `nuke-me` to exist on disk | ||
| expect(await otherCache.get('nuke-me')).toBe('genesis'); | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| expect(await otherCache.get(`key${i}`)).toBeUndefined(); | ||
| } | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); |
Oops, something went wrong.