(aws-sam): ContentUri in LayerVersion does not support S3 bucket/key

[jamesls]

The ContentUri for AWS::Serverless::LayerVersion requires the value to be a string in the CDK (https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_sam/CfnLayerVersion.html), but the spec allows it also be an S3 Location.

Property Name	Type	Description
ContentUri	string | S3 Location Object	Required. S3 Uri or location for the layer code.

This is due to the SAM schema the CDK uses missing this additional type. This has now been fixed upstream (awslabs/goformation#339), but the PR to pull in this change into the CDK was closed (#12370). Can we get that PR reopened and merged?

Reproduction Steps

Create an aws_sam.CfnLayerVersion object. The content URI must be a string.

What did you expect to happen?

I'd like to be able to specify an S3 bucket and key (in my case I'm using aws_s3_assets.Asset)

What actually happened?

If you manually try to override this and provide your own s3 bucket/key you'll get a validation error as you'd expect because the schema doesn't support this.

  Error: Resolution error: Supplied properties not correct for "CfnLayerVersionProps"
    contentUri: {"Bucket":{"Ref":"AssetParameters59ed3761e0090e8d958742734d21a2470d6d8232f489fc7a13b7c391e1e259ccS3Bucket4BD22AB4"},"Key":{"Fn::Join":["",[{"Fn::Select":[0,{"Fn::Split":["||",{"Ref":"AssetParameters59ed3761e0090e8d958742734d21a2470d6d8232f489fc7a13b7c391e1e259ccS3VersionKeyB8AFB4C8"}]}]},{"Fn::Select":[1,{"Fn::Split":["||",{"Ref":"AssetParameters59ed3761e0090e8d958742734d21a2470d6d8232f489fc7a13b7c391e1e259ccS3VersionKeyB8AFB4C8"}]}]}]]}} should be a string.
      at ValidationResult.assertSuccess (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/runtime.js:137:19)
      at cfnLayerVersionPropsToCloudFormation (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/aws-sam/lib/sam.generated.js:2864:47)
      at CfnLayerVersion.renderProperties (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/aws-sam/lib/sam.generated.js:2959:16)
      at PostResolveToken.ret.Resources [as processor] (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/cfn-resource.js:291:52)
      at PostResolveToken.postProcess (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/util.js:81:21)
      at Object.postProcess (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/private/resolve.js:31:82)
      at DefaultTokenResolver.resolveToken (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/resolvable.js:55:38)
      at resolve (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/private/resolve.js:100:33)
      at Object.resolve (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/private/resolve.js:29:33)
      at resolve (/private/var/folders/rb/4c1d0xbd18g_wxjcjlvb0whn1cjh5m/T/jsii-kernel-ym3ebW/node_modules/@aws-cdk/core/lib/private/resolve.js:118:43)

Environment

• **CDK CLI Version :1.83.0 (build 827c5f4)
• **Framework Version:1.83.0 (build 827c5f4)
• **Node.js Version:v14.13.0
• **OS :macOS
• **Language (Version):Python 3.9

---

This is 🐛 Bug Report

[njlynch]

#12370 was closed, as it was superseded by #12490, which was merged in and released as part of v1.85.0. If you update, you should be able to assign an S3Location as the ContentURI.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.