fix(iam): not possible to represent Principal: *
#16843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some service's resource policies require the specification of
`Principal: *`, and will not accept `Principal: { AWS: * }`.
Our code was making assumptions that the two were compatible, and could
be interchangeably used. Our modelling made it impossible to represent
`Principal: *`.
- Fix an issue in `PolicyStatement.fromJson()` which would incorrectly normalize
away `Principal: *`.
- Add a new principal class, `StarPrincipal`, which represents the
principal of that type in the CDK object model.
|
|
otaviomacedo
approved these changes
Oct 7, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
hooray this confused the heck out of me |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
Some service's resource policies require the specification of
`Principal: *`, and will not accept `Principal: { AWS: * }`.
Our code was making assumptions that the two were compatible, and could
be interchangeably used. Our modelling made it impossible to represent
`Principal: *`.
- Fix an issue in `PolicyStatement.fromJson()` which would incorrectly normalize
away `Principal: *`.
- Add a new principal class, `StarPrincipal`, which represents the
principal of that type in the CDK object model.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Some service's resource policies require the specification of
`Principal: *`, and will not accept `Principal: { AWS: * }`.
Our code was making assumptions that the two were compatible, and could
be interchangeably used. Our modelling made it impossible to represent
`Principal: *`.
- Fix an issue in `PolicyStatement.fromJson()` which would incorrectly normalize
away `Principal: *`.
- Add a new principal class, `StarPrincipal`, which represents the
principal of that type in the CDK object model.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some service's resource policies require the specification of
Principal: *, and will not acceptPrincipal: { AWS: * }.Our code was making assumptions that the two were compatible, and could
be interchangeably used. Our modelling made it impossible to represent
Principal: *.PolicyStatement.fromJson()which would incorrectly normalizeaway
Principal: *.StarPrincipal, which represents theprincipal of that type in the CDK object model.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license