Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: report undeleted resources after cdk destroy #21806

Open
2 tasks
boillodmanuel opened this issue Aug 29, 2022 · 7 comments
Open
2 tasks

cli: report undeleted resources after cdk destroy #21806

boillodmanuel opened this issue Aug 29, 2022 · 7 comments
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@boillodmanuel
Copy link

Describe the feature

Hi,

It would be nice if the CDK cli could report resources that will not be deleted by cdk destroy.
Ideally, this report is displayed before confirmation.

Note: This is a duplicate of #15749 which was closed automatically.
See this comment for possible workarounds.

Use Case

  • To have more information about what is happening
  • To prevent having some unused resources that are billed

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.38.1

Environment details (OS name and version, etc.)

any OS

@boillodmanuel boillodmanuel added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 29, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Aug 29, 2022
@niebloomj
Copy link

We also really need this in the console. Great idea!

@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2022
@peterwoodworth
Copy link
Contributor

Thanks for opening a new issue for visibility

The approach you've described to fetch stack resources seems feasible for us to implement without too much overhead

We accept contributions! Check out our contributing guide if you're interested - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@niebloomj
Copy link

Do you have any tips for where to look in the code to start hacking away at a solution here? Haven't contributed to this repo yet much. Once we build something into the cli for it, how do we go about getting it in the UI of the console? (amazonian here)

@peterwoodworth
Copy link
Contributor

We don't have any control over the console UI, since the CDK isn't its own service and relies on CloudFormation

This file is where our entrypoint and CLI options are 🙂

@TrygviZL
Copy link
Contributor

@niebloomj As the issue has been quiet for some time, I hope you don't mind if I give this one a shot :)

@peterwoodworth
Copy link
Contributor

Thank you very much for the PR @TrygviZL! We'll try to give it a review soon 🙂

@niebloomj
Copy link

@niebloomj As the issue has been quiet for some time, I hope you don't mind if I give this one a shot :)

Don't mind at all. Very much appreciated! Excited to learn from your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants