Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(eventbridge): setting resource option as an object #26092

Closed
2 tasks
ghost opened this issue Jun 22, 2023 · 5 comments
Closed
2 tasks

(eventbridge): setting resource option as an object #26092

ghost opened this issue Jun 22, 2023 · 5 comments
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@ghost
Copy link

ghost commented Jun 22, 2023

Describe the feature

I am trying to pass a prefix in the resources section of my event rule but the typing is limited to string[]. I should be able to pass an object, like { "prefix": "arn:aws:ecr" }

Use Case

To limit filtered resources to just a specific type, in this case, I want to set an event rule for all inspector2 findings from ECR, so the rule should look like:

{
  "source": ["aws.inspector2"],
  "detail-type": ["Inspector2 Finding"],
  "resources": [ {"prefix": "arn:aws:ecr"} ]
}

With the current implementation, I am limited to string[]

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.85.0

Environment details (OS name and version, etc.)

Mac OS

@ghost ghost added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2023
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Jun 22, 2023
@khushail khushail self-assigned this Jun 22, 2023
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jun 22, 2023
@khushail
Copy link
Contributor

@teitej , thanks for coming up with this feature request. Marking it as P2 as our team won't be immediately available to look into this. However if you would like to contribute, our team would be happy to review your PR.

@khushail khushail removed their assignment Jun 23, 2023
@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2023
@peterwoodworth
Copy link
Contributor

@teitej try using Match.prefix(), see our documentation here for more info on how to define patterns with the Match API.

@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 23, 2023
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 25, 2023
@ghost
Copy link
Author

ghost commented Jun 26, 2023

I will try this later today

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 26, 2023
@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jun 26, 2023
@ghost ghost closed this as completed Jun 27, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants