Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdk-assets: allow publish to local directory #26342

Closed
2 tasks
ArneOttenVW opened this issue Jul 13, 2023 · 2 comments
Closed
2 tasks

cdk-assets: allow publish to local directory #26342

ArneOttenVW opened this issue Jul 13, 2023 · 2 comments
Labels
@aws-cdk/aws-s3 Related to Amazon S3 closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@ArneOttenVW
Copy link

Describe the feature

Give cdk-assets a new option to not upload to cdk S3 bucket, but just keep the bundles on a local directory.

For example

cdk-assets local path/to/assets.json

Use Case

We are running a company-wide service on which people can pick a product to test out for a few days. For that, an AWS account gets provisioned and the product is deployed with cloudformation. For this, we need the json files and assets that cdk pushed to the cdk bucket.

Currently, we use cdk-assets publish to publish our product to a dev account, then redownload it and provide it as a product to the service. We would like to do this without the dev account so we can integrate it into our build pipeline more easily.

Proposed Solution

I did not take an extensive look at the code yet but just before upload, the files must be somewhere on the local drive. Just stop the process there and don't the delete the local files.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.84.0

Environment details (OS name and version, etc.)

Xubuntu 22.04

@ArneOttenVW ArneOttenVW added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Jul 13, 2023
@pahud
Copy link
Contributor

pahud commented Jul 13, 2023

cdk-assets essentially publish the cloud assembly from cdk.out based on the manifest file and everything should already be in cdk.out directory. I guess everything you need should already be there.

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants