opensearchservice: creating OpenSearch domain from Endpoint results in malformed ARN when using VPC endpoint

[martingrzzler]

Describe the bug

Calling Domain.fromDomainEndpoint leads to wrong domainArn when called with a VPC endpoint.

Domain.fromDomainEndpoint(
      this,
      'OpenSearchDomain',
      'https://vpc-name-xxxxxxxxx.region.es.amazonaws.com',
    )

The problem is caused by the extractNameFromEndpoint function.

Expected Behavior

Given endpoint https://vpc-name-xxxxxxxxx.region.es.amazonaws.com
Expect extractNameFromEndpoint to return name

Current Behavior

Actual vpc-name

Reproduction Steps

const domain = Domain.fromDomainEndpoint(
      this,
      'OpenSearchDomain',
      'https://vpc-name-xxxxxxxxx.region.es.amazonaws.com',
    )
    new CfnOutput(this, 'DomainArn', { // wrong ARN starting with name vpc-
      value: domain.domainArn,
    })

Possible Solution

function extractNameFromEndpoint(domainEndpoint: string) {
  const { hostname } = new URL(domainEndpoint);
  const domain = hostname.split(".")[0];
  const parts = domain.split("-");

  return parts.length === 3 ? parts[1] : parts[0];
}

Additional Information/Context

No response

CDK CLI Version

2.136.0

Framework Version

No response

Node.js Version

v21.6.0

OS

macOS

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Sounds like it only happens when called with a VPC endpoint.

Thank you for the report and feel free to submit a PR to help us address this bug.