Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lambda-nodejs): breaking change in esbuild causes import module error #30726

Merged
merged 8 commits into from
Jul 1, 2024
Merged

fix(lambda-nodejs): breaking change in esbuild causes import module error #30726

merged 8 commits into from
Jul 1, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Jul 1, 2024 •
edited
Loading

Issue # (if applicable)

Closes #30717.

Reason for this change

esbuild introduced a breaking change in v0.22 which caused the build error in aws-lambda-nodejs module.

Description of changes

Pin the esbuild version to 0.21 in Dockerfile

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 1, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 1, 2024 17:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 1, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p0 and removed p2 labels Jul 1, 2024
@xazhao xazhao changed the title fix(aws-lambda-nodejs): pin the esbuild minor version fix(aws-lambda-nodejs): Runtime.ImportModuleError because of new esbuild version Jul 1, 2024
@xazhao @mrgrain
Update packages/aws-cdk-lib/aws-lambda-nodejs/lib/Dockerfile
fa9476c 
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(aws-lambda-nodejs): Runtime.ImportModuleError because of new esbuild version fix(lambda-nodejs): Runtime.ImportModuleError because of new esbuild version Jul 1, 2024
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(lambda-nodejs): Runtime.ImportModuleError because of new esbuild version fix(lambda-nodejs): breaking change in exbuild causes Runtime.ImportModuleError Jul 1, 2024
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(lambda-nodejs): breaking change in exbuild causes Runtime.ImportModuleError fix(lambda-nodejs): breaking change in esbuild causes import module error Jul 1, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 1, 2024 20:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@xazhao xazhao marked this pull request as ready for review July 1, 2024 20:24
scanlonp
scanlonp approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is going on with the tree.json changes. The code changes look good.

...-testing/framework-integ/test/aws-lambda-nodejs/test/integ.esbuildArgs.js.snapshot/tree.json
Comment on lines +23 to +24
"fqn": "aws-cdk-lib.Resource",
"version": "0.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to be changing like this? Are these updates that should have happened but are only being found now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but these haven't been updated in a while so it's likely as a result of the jsii changes that were merged recently. I expected some of this.

@scanlonp scanlonp added the pr/do-not-merge This PR should not be merged at this time. label Jul 1, 2024
@TheRealAmazonKendra TheRealAmazonKendra removed the pr/do-not-merge This PR should not be merged at this time. label Jul 1, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bce1753
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7f5ce4b into aws:main Jul 1, 2024
20 checks passed
xazhao added a commit that referenced this pull request Jul 1, 2024
@xazhao
fix(lambda-nodejs): breaking change in esbuild causes import module e…
06c14b1 
…rror (#30726)

### Issue # (if applicable)

Closes #30717.

### Reason for this change

esbuild introduced a breaking change in v0.22 which caused the build error in `aws-lambda-nodejs` module.

### Description of changes

Pin the esbuild version to 0.21 in Dockerfile

### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@statefb statefb mentioned this pull request Jul 2, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Closed
@konokenj konokenj mentioned this pull request Jul 11, 2024
Closed
@azu azu mentioned this pull request Jul 11, 2024
Merged
@NOUIY NOUIY mentioned this pull request Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrgrain mrgrain mrgrain left review comments

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra left review comments

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❗ NOTICE (aws-lambda-nodejs): Runtime.ImportModuleError: Cannot find module 'module'
5 participants
@xazhao @aws-cdk-automation @mrgrain @TheRealAmazonKendra @scanlonp