CI: Fail build if tracked files are modified

[nmussy]

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

• I'm submitting a ...

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior?
  If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
  Builds do not fail at the end of the ./build.sh script when tracked files have been modified or deleted, or files have been added in tracked directories.

• What is the expected behavior (or behavior of feature suggested)?
  Fail the build if git status --porcelain is not empty

• What is the motivation / use case for changing the behavior or adding this feature?
  When building 6c0bf4a, all packages/*/package-lock.json have the following diff:

- "@aws-cdk/cfnspec": "^1.1.0",
+ "@aws-cdk/cfnspec": "^1.2.0",

Something similar happened with 1.1.0 if I remember correctly.

In any case, the build shouldn't create, update or delete any tracked files.

• Please tell us about your environment:

  • CDK CLI Version: 1.2.0
  • Module Version: 1.2.0
  • OS: all
  • Language: all

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

If this is implemented, we should probably add **/.idea to the .gitignore file, to allow WebStorm users to build without stashing their IDE config folder

[nmussy]

I just realized that this would require something like a --ci flag, otherwise it would make the script unusable during development

[RomainMuller]

That's indeed a very good idea!!