Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): prohibit the build causes source changes #3508

Merged
merged 10 commits into from Aug 12, 2019

Conversation

RomainMuller
Copy link
Contributor

Verify that the build process does not cause changes in git tracked
files.

Fixes #3451


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Verify that the build process does not cause changes in git tracked
files.

Fixes #3451
eladb
eladb previously approved these changes Aug 1, 2019
@NGL321 NGL321 added the management/devenv Related to CDK development/build environment label Aug 1, 2019
skinny85
skinny85 previously approved these changes Aug 5, 2019
@NGL321 NGL321 removed the management/devenv Related to CDK development/build environment label Aug 6, 2019
@nmussy
Copy link
Contributor

nmussy commented Aug 8, 2019

@RomainMuller git diff-index won't list untracked files. Is that an issue?

@RomainMuller
Copy link
Contributor Author

@nmussy I guess you're right there's a bit of a case of un-ignored, un-tracked files being violators, too. Thanks for pointing out!

@RomainMuller RomainMuller dismissed stale reviews from skinny85 and eladb via c9afc9a August 8, 2019 15:52
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new package-lock.json addition intentional, or was it just missing from the new package?

@mergify mergify bot merged commit 9f1bfae into master Aug 12, 2019
@RomainMuller
Copy link
Contributor Author

It was missing apparently.

@RomainMuller RomainMuller deleted the rmuller/no-unstaged-change branch August 12, 2019 17:38
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fail build if tracked files are modified
5 participants