feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget #4868

KingOfPoptart · 2019-11-05T20:28:33Z

We found a gap in route53 targets. This new target takes in an ec2.IInterfaceVpcEndpoint and sets it as an alias target for Route53.

While I acknowledge the implementation isn't the prettiest, it works, is tested, and I'm all ears for improvement.

mergify · 2019-11-05T20:29:11Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

aws-cdk-automation · 2019-11-05T20:52:17Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-05T20:58:19Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-05T21:18:20Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-05T22:01:51Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2019-11-05T22:31:18Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

flemjame-at-amazon · 2019-12-11T14:28:11Z

Will this make it into the next revision of CDK? I've written my own workaround InterfaceVpcEndpointTarget class and I'd love to delete it from my codebase.

mergify · 2019-12-16T12:34:08Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:01:20Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T13:53:27Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:39:12Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T14:52:55Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

mergify · 2019-12-16T15:18:13Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

Updating to master

KingOfPoptart · 2020-01-06T17:32:39Z

@shivlaks Hiya - can anybody take a look at this please?

aws-cdk-automation · 2020-01-06T17:45:17Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Merge pull request #1 from aws/master

aws-cdk-automation · 2020-01-06T18:02:46Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks · 2019-12-19T19:54:32Z

packages/@aws-cdk/aws-route53-targets/lib/interface-vpc-endpoint-target.ts

+      dnsName: cdk.Fn.select(1, cdk.Fn.split(':', cdk.Fn.select(0, this.cfnVpcEndpoint.attrDnsEntries))),
+      hostedZoneId: cdk.Fn.select(0, cdk.Fn.split(':', cdk.Fn.select(0, this.cfnVpcEndpoint.attrDnsEntries))),


is this always guaranteed to work?

So far in our testing this has worked 100% of the time. Not the best way of implementing, but currently its the only way we've found to make this work.

Looking at the AWS docs, the first DNS entry is the regional one, the first part of it is the hosted zone, and the second part is the dns name:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-vpcendpoint.html

It's not enforced for AWS marketplace services though, which doesn't guarantee any order. Maybe make a readme note that this only applies to non-marketplace services?

@flemjame-at-amazon good suggestion, added

shivlaks · 2019-12-19T19:54:57Z

packages/@aws-cdk/aws-route53-targets/lib/interface-vpc-endpoint-target.ts

@@ -0,0 +1,20 @@
+import ec2 = require('@aws-cdk/aws-ec2');
+import r53 = require('@aws-cdk/aws-route53');


minor: please name it route53

shivlaks · 2019-12-19T19:57:33Z

packages/@aws-cdk/aws-route53-targets/test/integ.interface-vpc-endpoint-target.ts

@@ -0,0 +1,33 @@
+import ec2 = require('@aws-cdk/aws-ec2');
+import r53 = require('@aws-cdk/aws-route53');


minor: route53

shivlaks · 2020-01-15T19:14:30Z

@shivlaks Hiya - can anybody take a look at this please?

my apologies, I looked at this a long time ago and it turns out I didn't publish the comments... my bad!

Merge master

aws-cdk-automation · 2020-01-15T19:43:29Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T19:45:10Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T19:50:42Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T21:41:38Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T21:52:17Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T21:58:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-15T22:06:58Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…/aws-cdk into interfaceVpcEndpointTarget

aws-cdk-automation · 2020-01-15T23:36:56Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

merge master

aws-cdk-automation · 2020-01-16T18:08:36Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-01-16T21:57:37Z

Thank you for contributing! Your pull request is now being automatically merged.

Add InterfaceVpcEndpointTarget

46c9f38

KingOfPoptart requested a review from shivlaks as a code owner November 5, 2019 20:28

KingOfPoptart changed the title ~~Add InterfaceVpcEndpointTarget~~ Add aws-route53-targets/InterfaceVpcEndpointTarget Nov 5, 2019

KingOfPoptart changed the title ~~Add aws-route53-targets/InterfaceVpcEndpointTarget~~ feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget Nov 5, 2019

SomayaB assigned shivlaks Nov 5, 2019

Update RecordTarget

9f0a74e

Revert yarn.lock

16f1960

Fix tests

435cfb5

Revert integ json

6d16f89

KingOfPoptart added 2 commits January 6, 2020 09:01

Merge pull request #1 from aws/master

f5d3ab8

Updating to master

Merge branch 'master' into interfaceVpcEndpointTarget

cdb78d8

Merge pull request #2 from KingOfPoptart/master

2cb0853

Merge pull request #1 from aws/master

shivlaks reviewed Jan 15, 2020

View reviewed changes

richduar and others added 3 commits January 15, 2020 11:30

Rename r53 to route53

70993b7

Rename r53 to route53

83a8f0a

Merge pull request #3 from aws/master

0bff0bd

Merge master

richduar and others added 5 commits January 15, 2020 13:04

Update tests, and README

dec0dca

Fix deps

bd8e486

Fix devDep

6774535

Remove newline

8b73896

Merge branch 'master' into interfaceVpcEndpointTarget

b21db18

richduar added 2 commits January 15, 2020 14:51

Fix grammar

88527e3

Merge branch 'interfaceVpcEndpointTarget' of github.com:KingOfPoptart…

9bbb791

…/aws-cdk into interfaceVpcEndpointTarget

KingOfPoptart and others added 2 commits January 16, 2020 09:20

Merge pull request #4 from aws/master

3304d48

merge master

Merge master

9cc173f

shivlaks approved these changes Jan 16, 2020

View reviewed changes

mergify bot merged commit 6969562 into aws:master Jan 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget #4868

feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget #4868

KingOfPoptart commented Nov 5, 2019

mergify bot commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

flemjame-at-amazon commented Dec 11, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

KingOfPoptart commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

shivlaks Dec 19, 2019

KingOfPoptart Jan 15, 2020

flemjame-at-amazon Jan 15, 2020

KingOfPoptart Jan 15, 2020

shivlaks Dec 19, 2019

shivlaks Dec 19, 2019

shivlaks commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 16, 2020

mergify bot commented Jan 16, 2020

		dnsName: cdk.Fn.select(1, cdk.Fn.split(':', cdk.Fn.select(0, this.cfnVpcEndpoint.attrDnsEntries))),
		hostedZoneId: cdk.Fn.select(0, cdk.Fn.split(':', cdk.Fn.select(0, this.cfnVpcEndpoint.attrDnsEntries))),

		@@ -0,0 +1,20 @@
		import ec2 = require('@aws-cdk/aws-ec2');
		import r53 = require('@aws-cdk/aws-route53');

		@@ -0,0 +1,33 @@
		import ec2 = require('@aws-cdk/aws-ec2');
		import r53 = require('@aws-cdk/aws-route53');

feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget #4868

feat(route53-targets): Add aws-route53-targets/InterfaceVpcEndpointTarget #4868

Conversation

KingOfPoptart commented Nov 5, 2019

mergify bot commented Nov 5, 2019

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

aws-cdk-automation commented Nov 5, 2019

AWS CodeBuild CI Report

flemjame-at-amazon commented Dec 11, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

mergify bot commented Dec 16, 2019

KingOfPoptart commented Jan 6, 2020

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 6, 2020

AWS CodeBuild CI Report

shivlaks Dec 19, 2019

Choose a reason for hiding this comment

KingOfPoptart Jan 15, 2020

Choose a reason for hiding this comment

flemjame-at-amazon Jan 15, 2020

Choose a reason for hiding this comment

KingOfPoptart Jan 15, 2020

Choose a reason for hiding this comment

shivlaks Dec 19, 2019

Choose a reason for hiding this comment

shivlaks Dec 19, 2019

Choose a reason for hiding this comment

shivlaks commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 16, 2020

AWS CodeBuild CI Report

mergify bot commented Jan 16, 2020